From 668459f88fdef5f385759e53ee7f5206131da98b Mon Sep 17 00:00:00 2001 From: crupest Date: Sat, 29 Feb 2020 17:29:57 +0800 Subject: Guess what, Chinese character is also a "letter". So no need to change code. Just add some tests. --- Timeline.Tests/UsernameValidatorUnitTest.cs | 2 ++ Timeline/Models/Validation/NameValidator.cs | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Timeline.Tests/UsernameValidatorUnitTest.cs b/Timeline.Tests/UsernameValidatorUnitTest.cs index 0f844452..8824362b 100644 --- a/Timeline.Tests/UsernameValidatorUnitTest.cs +++ b/Timeline.Tests/UsernameValidatorUnitTest.cs @@ -39,6 +39,7 @@ namespace Timeline.Tests [InlineData("!")] [InlineData("!abc")] [InlineData("ab c")] + [InlineData("ab c！")] // This is a chinese ! . public void BadCharactor(string value) { FailAndMessage(value).Should().ContainEquivalentOf("invalid") @@ -61,6 +62,7 @@ namespace Timeline.Tests [InlineData("a-bc")] [InlineData("a-b-c")] [InlineData("a-b_c")] + [InlineData("a-你好_c")] public void Success(string value) { var (result, _) = _validator.Validate(value); diff --git a/Timeline/Models/Validation/NameValidator.cs b/Timeline/Models/Validation/NameValidator.cs index 8db10ebd..dec2b872 100644 --- a/Timeline/Models/Validation/NameValidator.cs +++ b/Timeline/Models/Validation/NameValidator.cs @@ -14,7 +14,7 @@ namespace Timeline.Models.Validation return (false, MessageEmptyString); } - if (value.Length > 26) + if (value.Length > MaxLength) { return (false, MessageTooLong); } -- cgit v1.2.3