From a672e10faad434899d81ef9d0d0d5adbbc7841da Mon Sep 17 00:00:00 2001 From: crupest Date: Fri, 30 Apr 2021 16:52:55 +0800 Subject: refactor: ... --- .../Controllers/BookmarkTimelineController.cs | 30 +++++----------------- 1 file changed, 6 insertions(+), 24 deletions(-) (limited to 'BackEnd/Timeline/Controllers/BookmarkTimelineController.cs') diff --git a/BackEnd/Timeline/Controllers/BookmarkTimelineController.cs b/BackEnd/Timeline/Controllers/BookmarkTimelineController.cs index cbc96fc6..94cb0f3e 100644 --- a/BackEnd/Timeline/Controllers/BookmarkTimelineController.cs +++ b/BackEnd/Timeline/Controllers/BookmarkTimelineController.cs @@ -60,16 +60,9 @@ namespace Timeline.Controllers [ProducesResponseType(401)] public async Task> Put([GeneralTimelineName] string timeline) { - try - { - var timelineId = await _timelineService.GetTimelineIdByNameAsync(timeline); - var create = await _service.AddBookmarkAsync(this.GetUserId(), timelineId); - return CommonPutResponse.Create(create); - } - catch (TimelineNotExistException) - { - return BadRequest(ErrorResponse.TimelineController.NotExist()); - } + var timelineId = await _timelineService.GetTimelineIdByNameAsync(timeline); + var create = await _service.AddBookmarkAsync(this.GetUserId(), timelineId); + return CommonPutResponse.Create(create); } /// @@ -83,16 +76,9 @@ namespace Timeline.Controllers [ProducesResponseType(401)] public async Task> Delete([GeneralTimelineName] string timeline) { - try - { - var timelineId = await _timelineService.GetTimelineIdByNameAsync(timeline); - var delete = await _service.RemoveBookmarkAsync(this.GetUserId(), timelineId); - return CommonDeleteResponse.Create(delete); - } - catch (TimelineNotExistException) - { - return BadRequest(ErrorResponse.TimelineController.NotExist()); - } + var timelineId = await _timelineService.GetTimelineIdByNameAsync(timeline); + var delete = await _service.RemoveBookmarkAsync(this.GetUserId(), timelineId); + return CommonDeleteResponse.Create(delete); } /// @@ -112,10 +98,6 @@ namespace Timeline.Controllers await _service.MoveBookmarkAsync(this.GetUserId(), timelineId, request.NewPosition!.Value); return Ok(); } - catch (TimelineNotExistException) - { - return BadRequest(ErrorResponse.TimelineController.NotExist()); - } catch (InvalidBookmarkException) { return BadRequest(new CommonResponse(ErrorCodes.BookmarkTimelineController.NonBookmark, "You can't move a non-bookmark timeline.")); -- cgit v1.2.3