From 14f9493d41738a8b3523ed498838ad1f373b9377 Mon Sep 17 00:00:00 2001
From: crupest <crupest@outlook.com>
Date: Wed, 20 Nov 2019 00:32:32 +0800
Subject: Add delete nonexist post test, and fix the bug.

---
 Timeline/Controllers/PersonalTimelineController.cs | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

(limited to 'Timeline/Controllers/PersonalTimelineController.cs')

diff --git a/Timeline/Controllers/PersonalTimelineController.cs b/Timeline/Controllers/PersonalTimelineController.cs
index 88f5ba00..c864ed39 100644
--- a/Timeline/Controllers/PersonalTimelineController.cs
+++ b/Timeline/Controllers/PersonalTimelineController.cs
@@ -107,14 +107,14 @@ namespace Timeline.Controllers
         [CatchTimelineNotExistException]
         public async Task<ActionResult> PostOperationDelete([FromRoute][Username] string username, [FromBody] TimelinePostDeleteRequest body)
         {
-            var postId = body.Id!.Value;
-            if (!IsAdmin() && !await _service.HasPostModifyPermission(username, postId, GetAuthUsername()!))
-            {
-                return StatusCode(StatusCodes.Status403Forbidden,
-                    new CommonResponse(ErrorCodes.Http.Timeline.PostOperationDeleteForbid, MessagePostOperationCreateForbid));
-            }
             try
             {
+                var postId = body.Id!.Value;
+                if (!IsAdmin() && !await _service.HasPostModifyPermission(username, postId, GetAuthUsername()!))
+                {
+                    return StatusCode(StatusCodes.Status403Forbidden,
+                        new CommonResponse(ErrorCodes.Http.Timeline.PostOperationDeleteForbid, MessagePostOperationCreateForbid));
+                }
                 await _service.DeletePost(username, postId);
             }
             catch (TimelinePostNotExistException)
-- 
cgit v1.2.3