From c3369742b6e68714d0a7df46a99a0798eb2d6940 Mon Sep 17 00:00:00 2001 From: crupest Date: Tue, 11 Aug 2020 01:48:57 +0800 Subject: Handle post deletion on user deletion correctly. --- Timeline/Services/UserService.cs | 44 ---------------------------------------- 1 file changed, 44 deletions(-) (limited to 'Timeline/Services/UserService.cs') diff --git a/Timeline/Services/UserService.cs b/Timeline/Services/UserService.cs index 4e56c86a..c186c170 100644 --- a/Timeline/Services/UserService.cs +++ b/Timeline/Services/UserService.cs @@ -126,22 +126,6 @@ namespace Timeline.Services /// Task ModifyUser(string username, User? info); - /// - /// Delete a user of given id. - /// - /// Id of the user to delete. - /// True if user is deleted, false if user not exist. - Task DeleteUser(long id); - - /// - /// Delete a user of given username. - /// - /// Username of the user to delete. Can't be null. - /// True if user is deleted, false if user not exist. - /// Thrown if is null. - /// Thrown when is of bad format. - Task DeleteUser(string username); - /// /// Try to change a user's password with old password. /// @@ -428,34 +412,6 @@ namespace Timeline.Services return CreateUserFromEntity(entity); } - public async Task DeleteUser(long id) - { - var user = await _databaseContext.Users.Where(u => u.Id == id).SingleOrDefaultAsync(); - if (user == null) - return false; - - _databaseContext.Users.Remove(user); - await _databaseContext.SaveChangesAsync(); - _logger.LogInformation(Log.Format(LogDatabaseRemove, ("Id", id), ("Username", user.Username))); - return true; - } - - public async Task DeleteUser(string username) - { - if (username == null) - throw new ArgumentNullException(nameof(username)); - CheckUsernameFormat(username, nameof(username)); - - var user = await _databaseContext.Users.Where(u => u.Username == username).SingleOrDefaultAsync(); - if (user == null) - return false; - - _databaseContext.Users.Remove(user); - await _databaseContext.SaveChangesAsync(); - _logger.LogInformation(Log.Format(LogDatabaseRemove, ("Id", user.Id), ("Username", username))); - return true; - } - public async Task ChangePassword(long id, string oldPassword, string newPassword) { if (oldPassword == null) -- cgit v1.2.3