From 12410a51fb2e5f55e8d83415bc3c4053a146ce3b Mon Sep 17 00:00:00 2001
From: crupest <crupest@outlook.com>
Date: Fri, 28 Aug 2020 00:01:04 +0800
Subject: Add change timeline name api to timeline controller.

---
 Timeline/Controllers/TimelineController.cs | 26 ++++++++++++++++++++++++++
 Timeline/Filters/Timeline.cs               | 13 ++++++++++---
 Timeline/Models/Http/TimelineController.cs | 19 +++++++++++++++++++
 Timeline/Services/TimelineService.cs       |  3 ++-
 4 files changed, 57 insertions(+), 4 deletions(-)

(limited to 'Timeline')

diff --git a/Timeline/Controllers/TimelineController.cs b/Timeline/Controllers/TimelineController.cs
index 90b50bbb..9a3147ea 100644
--- a/Timeline/Controllers/TimelineController.cs
+++ b/Timeline/Controllers/TimelineController.cs
@@ -308,6 +308,7 @@ namespace Timeline.Controllers
         [HttpDelete("timelines/{name}/posts/{id}")]
         [Authorize]
         [ProducesResponseType(StatusCodes.Status200OK)]
+        [ProducesResponseType(StatusCodes.Status400BadRequest)]
         [ProducesResponseType(StatusCodes.Status401Unauthorized)]
         [ProducesResponseType(StatusCodes.Status403Forbidden)]
         public async Task<ActionResult<CommonDeleteResponse>> PostDelete([FromRoute][GeneralTimelineName] string name, [FromRoute] long id)
@@ -336,6 +337,7 @@ namespace Timeline.Controllers
         [HttpPatch("timelines/{name}")]
         [Authorize]
         [ProducesResponseType(StatusCodes.Status200OK)]
+        [ProducesResponseType(StatusCodes.Status400BadRequest)]
         [ProducesResponseType(StatusCodes.Status401Unauthorized)]
         [ProducesResponseType(StatusCodes.Status403Forbidden)]
         public async Task<ActionResult<TimelineInfo>> TimelinePatch([FromRoute][GeneralTimelineName] string name, [FromBody] TimelinePatchRequest body)
@@ -461,5 +463,29 @@ namespace Timeline.Controllers
                 return CommonDeleteResponse.NotExist();
             }
         }
+
+        [HttpPost("timelineop/changename")]
+        [Authorize]
+        [ProducesResponseType(StatusCodes.Status200OK)]
+        [ProducesResponseType(StatusCodes.Status400BadRequest)]
+        [ProducesResponseType(StatusCodes.Status401Unauthorized)]
+        [ProducesResponseType(StatusCodes.Status403Forbidden)]
+        public async Task<ActionResult<TimelineInfo>> TimelineOpChangeName([FromBody] TimelineChangeNameRequest body)
+        {
+            if (!this.IsAdministrator() && !(await _service.HasManagePermission(body.OldName, this.GetUserId())))
+            {
+                return StatusCode(StatusCodes.Status403Forbidden, ErrorResponse.Common.Forbid());
+            }
+
+            try
+            {
+                var timeline = await _service.ChangeTimelineName(body.OldName, body.NewName);
+                return Ok(_mapper.Map<TimelineInfo>(timeline));
+            }
+            catch (EntityAlreadyExistException)
+            {
+                return BadRequest(ErrorResponse.TimelineController.NameConflict());
+            }
+        }
     }
 }
diff --git a/Timeline/Filters/Timeline.cs b/Timeline/Filters/Timeline.cs
index 90b87223..6a730ee7 100644
--- a/Timeline/Filters/Timeline.cs
+++ b/Timeline/Filters/Timeline.cs
@@ -1,4 +1,5 @@
-using Microsoft.AspNetCore.Mvc;
+using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Mvc;
 using Microsoft.AspNetCore.Mvc.Filters;
 using Timeline.Models.Http;
 using Timeline.Services.Exceptions;
@@ -13,11 +14,17 @@ namespace Timeline.Filters
             {
                 if (e.InnerException is UserNotExistException)
                 {
-                    context.Result = new NotFoundObjectResult(ErrorResponse.UserCommon.NotExist());
+                    if (HttpMethods.IsGet(context.HttpContext.Request.Method))
+                        context.Result = new NotFoundObjectResult(ErrorResponse.UserCommon.NotExist());
+                    else
+                        context.Result = new BadRequestObjectResult(ErrorResponse.UserCommon.NotExist());
                 }
                 else
                 {
-                    context.Result = new NotFoundObjectResult(ErrorResponse.TimelineController.NotExist());
+                    if (HttpMethods.IsGet(context.HttpContext.Request.Method))
+                        context.Result = new NotFoundObjectResult(ErrorResponse.TimelineController.NotExist());
+                    else
+                        context.Result = new BadRequestObjectResult(ErrorResponse.TimelineController.NotExist());
                 }
             }
         }
diff --git a/Timeline/Models/Http/TimelineController.cs b/Timeline/Models/Http/TimelineController.cs
index 95bae3e6..7bd141ed 100644
--- a/Timeline/Models/Http/TimelineController.cs
+++ b/Timeline/Models/Http/TimelineController.cs
@@ -71,4 +71,23 @@ namespace Timeline.Models.Http
         /// </summary>
         public TimelineVisibility? Visibility { get; set; }
     }
+
+    /// <summary>
+    /// Change timeline name request model.
+    /// </summary>
+    public class TimelineChangeNameRequest
+    {
+        /// <summary>
+        /// Old name of timeline.
+        /// </summary>
+        [Required]
+        [TimelineName]
+        public string OldName { get; set; } = default!;
+        /// <summary>
+        /// New name of timeline.
+        /// </summary>
+        [Required]
+        [TimelineName]
+        public string NewName { get; set; } = default!;
+    }
 }
diff --git a/Timeline/Services/TimelineService.cs b/Timeline/Services/TimelineService.cs
index 0a3a2076..4bcae596 100644
--- a/Timeline/Services/TimelineService.cs
+++ b/Timeline/Services/TimelineService.cs
@@ -411,6 +411,7 @@ namespace Timeline.Services
             }
         }
 
+        /// Remember to include Members when query.
         private async Task<Models.Timeline> MapTimelineFromEntity(TimelineEntity entity)
         {
             var owner = await _userService.GetUserById(entity.OwnerId);
@@ -1138,7 +1139,7 @@ namespace Timeline.Services
             ValidateTimelineName(oldTimelineName, nameof(oldTimelineName));
             ValidateTimelineName(newTimelineName, nameof(newTimelineName));
 
-            var entity = await _database.Timelines.Where(t => t.Name == oldTimelineName).SingleOrDefaultAsync();
+            var entity = await _database.Timelines.Include(t => t.Members).Where(t => t.Name == oldTimelineName).SingleOrDefaultAsync();
 
             if (entity == null)
                 throw new TimelineNotExistException(oldTimelineName);
-- 
cgit v1.2.3