From 794352a92f09425714b9116974b29e58ce8f9ba9 Mon Sep 17 00:00:00 2001 From: Abseil Team Date: Wed, 20 Dec 2023 14:52:25 -0800 Subject: Performance improvement for absl::AsciiStrToUpper() and absl::AsciiStrToLower() PiperOrigin-RevId: 592664369 Change-Id: I7aa7b045c2b3c0f25cff7b82eb9d9cc13e9fc49f --- absl/strings/ascii.cc | 66 ++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 63 insertions(+), 3 deletions(-) (limited to 'absl/strings/ascii.cc') diff --git a/absl/strings/ascii.cc b/absl/strings/ascii.cc index df905e05..5460b2c6 100644 --- a/absl/strings/ascii.cc +++ b/absl/strings/ascii.cc @@ -15,8 +15,10 @@ #include "absl/strings/ascii.h" #include +#include #include #include +#include #include "absl/base/config.h" #include "absl/base/nullability.h" @@ -160,6 +162,19 @@ ABSL_DLL const char kToUpper[256] = { }; // clang-format on +template +static constexpr T BroadcastByte(unsigned char value) { + static_assert(std::is_integral::value && sizeof(T) <= sizeof(uint64_t) && + std::is_unsigned::value, + "only unsigned integers up to 64-bit allowed"); + T result = value; + constexpr size_t result_bit_width = sizeof(result) * CHAR_BIT; + result |= result << ((CHAR_BIT << 0) & (result_bit_width - 1)); + result |= result << ((CHAR_BIT << 1) & (result_bit_width - 1)); + result |= result << ((CHAR_BIT << 2) & (result_bit_width - 1)); + return result; +} + // Returns whether `c` is in the a-z/A-Z range (w.r.t. `ToUpper`). // Implemented by: // 1. Pushing the a-z/A-Z range to [SCHAR_MIN, SCHAR_MIN + 26). @@ -175,8 +190,46 @@ constexpr bool AsciiInAZRange(unsigned char c) { } template -constexpr void AsciiStrCaseFold(absl::Nonnull p, - absl::Nonnull end) { +static constexpr char* PartialAsciiStrCaseFold(absl::Nonnull p, + absl::Nonnull end) { + using vec_t = size_t; + const size_t n = static_cast(end - p); + + // SWAR algorithm: http://0x80.pl/notesen/2016-01-06-swar-swap-case.html + constexpr char ch_a = ToUpper ? 'a' : 'A', ch_z = ToUpper ? 'z' : 'Z'; + char* const swar_end = p + (n / sizeof(vec_t)) * sizeof(vec_t); + while (p < swar_end) { + vec_t v = vec_t(); + + // memcpy the vector, but constexpr + for (size_t i = 0; i < sizeof(vec_t); ++i) { + v |= static_cast(static_cast(p[i])) + << (i * CHAR_BIT); + } + + constexpr unsigned int msb = 1u << (CHAR_BIT - 1); + const vec_t v_msb = v & BroadcastByte(msb); + const vec_t v_nonascii_mask = (v_msb << 1) - (v_msb >> (CHAR_BIT - 1)); + const vec_t v_nonascii = v & v_nonascii_mask; + const vec_t v_ascii = v & ~v_nonascii_mask; + const vec_t a = v_ascii + BroadcastByte(msb - ch_a - 0), + z = v_ascii + BroadcastByte(msb - ch_z - 1); + v = v_nonascii | (v_ascii ^ ((a ^ z) & BroadcastByte(msb)) >> 2); + + // memcpy the vector, but constexpr + for (size_t i = 0; i < sizeof(vec_t); ++i) { + p[i] = static_cast(v >> (i * CHAR_BIT)); + } + + p += sizeof(v); + } + + return p; +} + +template +static constexpr void AsciiStrCaseFold(absl::Nonnull p, + absl::Nonnull end) { // The upper- and lowercase versions of ASCII characters differ by only 1 bit. // When we need to flip the case, we can xor with this bit to achieve the // desired result. Note that the choice of 'a' and 'A' here is arbitrary. We @@ -184,10 +237,17 @@ constexpr void AsciiStrCaseFold(absl::Nonnull p, // have the same single bit difference. constexpr unsigned char kAsciiCaseBitFlip = 'a' ^ 'A'; - for (; p < end; ++p) { + using vec_t = size_t; + // TODO(b/316380338): When FDO becomes able to vectorize these, + // revert this manual optimization and just leave the naive loop. + if (static_cast(end - p) >= sizeof(vec_t)) { + p = ascii_internal::PartialAsciiStrCaseFold(p, end); + } + while (p < end) { unsigned char v = static_cast(*p); v ^= AsciiInAZRange(v) ? kAsciiCaseBitFlip : 0; *p = static_cast(v); + ++p; } } -- cgit v1.2.3