From d573c1575825de8c47aaeca89db54226ff702924 Mon Sep 17 00:00:00 2001 From: Alexey Neyman Date: Wed, 26 Sep 2018 23:54:55 -0700 Subject: Use 'chmod a-x' instead of 'chmod -x' There is a subtle difference when executable bit is a part of the umask. And at least some versions (Debian/stretch) fail if the resulting mode would've been different if not for the umask setting. Fixes #998. Although, with such chmods/umasks it is likely that some package installation will break anyway. But I'll leave it until somebody complains. Signed-off-by: Alexey Neyman --- scripts/build/binutils/binutils.sh | 2 +- scripts/build/debug/300-gdb.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'scripts/build') diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh index 703a6fab..e8060ec5 100644 --- a/scripts/build/binutils/binutils.sh +++ b/scripts/build/binutils/binutils.sh @@ -223,7 +223,7 @@ do_binutils_backend() { sed -r -e "s/@@DEFAULT_LD@@/${CT_BINUTILS_LINKER_DEFAULT}/" \ "${CT_LIB_DIR}/scripts/build/binutils/binutils-ld.in" \ >"${prefix}/bin/${CT_TARGET}-ld" - chmod +x "${prefix}/bin/${CT_TARGET}-ld" + chmod a+x "${prefix}/bin/${CT_TARGET}-ld" cp -a "${prefix}/bin/${CT_TARGET}-ld" \ "${prefix}/${CT_TARGET}/bin/ld" diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gdb.sh index fe6ce79a..c73e4306 100644 --- a/scripts/build/debug/300-gdb.sh +++ b/scripts/build/debug/300-gdb.sh @@ -315,7 +315,7 @@ do_debug_gdb_build() { # Workaround for bad versions, where the configure # script for gdbserver is not executable... # Bah, GNU folks strike again... :-( - chmod +x "${gdb_src_dir}/gdb/gdbserver/configure" + chmod a+x "${gdb_src_dir}/gdb/gdbserver/configure" gdbserver_extra_config=("${extra_config[@]}") -- cgit v1.2.3