From 958686efa2175abe3f7044890c2c2370e29147f2 Mon Sep 17 00:00:00 2001 From: Flavio Cruz Date: Wed, 30 Nov 2022 02:14:20 -0500 Subject: Update ipc/ directory to use mach_port_name_t Make it explicit where we use port names versus actual ports. For the 64 bit kernel, port names and ports are of different size so this corrects the syscall arguments and internal structs to have the right size. This patch also uncovered several issues we need to solve to make GNUMach work well on 64 bits. First, the mach_msg call will receive 4 byte port names while the kernel "thinks" they are 8 bytes, which will be a problem. Also, when we send a message, the kernel translates the port names into port pointers in the message copied from user space. This also won't work on 64 bits. In this patch, I added several TODOs to fix the issues later. Message-Id: --- ipc/ipc_object.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'ipc/ipc_object.h') diff --git a/ipc/ipc_object.h b/ipc/ipc_object.h index be5bea71..209fae18 100644 --- a/ipc/ipc_object.h +++ b/ipc/ipc_object.h @@ -116,30 +116,30 @@ extern void ipc_object_release(ipc_object_t); extern kern_return_t -ipc_object_translate(ipc_space_t, mach_port_t, +ipc_object_translate(ipc_space_t, mach_port_name_t, mach_port_right_t, ipc_object_t *); extern kern_return_t -ipc_object_alloc_dead(ipc_space_t, mach_port_t *); +ipc_object_alloc_dead(ipc_space_t, mach_port_name_t *); extern kern_return_t -ipc_object_alloc_dead_name(ipc_space_t, mach_port_t); +ipc_object_alloc_dead_name(ipc_space_t, mach_port_name_t); extern kern_return_t ipc_object_alloc(ipc_space_t, ipc_object_type_t, mach_port_type_t, mach_port_urefs_t, - mach_port_t *, ipc_object_t *); + mach_port_name_t *, ipc_object_t *); extern kern_return_t ipc_object_alloc_name(ipc_space_t, ipc_object_type_t, mach_port_type_t, mach_port_urefs_t, - mach_port_t, ipc_object_t *); + mach_port_name_t, ipc_object_t *); extern mach_msg_type_name_t ipc_object_copyin_type(mach_msg_type_name_t); extern kern_return_t -ipc_object_copyin(ipc_space_t, mach_port_t, +ipc_object_copyin(ipc_space_t, mach_port_name_t, mach_msg_type_name_t, ipc_object_t *); extern void @@ -150,18 +150,18 @@ ipc_object_destroy(ipc_object_t, mach_msg_type_name_t); extern kern_return_t ipc_object_copyout(ipc_space_t, ipc_object_t, - mach_msg_type_name_t, boolean_t, mach_port_t *); + mach_msg_type_name_t, boolean_t, mach_port_name_t *); extern kern_return_t ipc_object_copyout_name(ipc_space_t, ipc_object_t, - mach_msg_type_name_t, boolean_t, mach_port_t); + mach_msg_type_name_t, boolean_t, mach_port_name_t); extern void ipc_object_copyout_dest(ipc_space_t, ipc_object_t, - mach_msg_type_name_t, mach_port_t *); + mach_msg_type_name_t, mach_port_name_t *); extern kern_return_t -ipc_object_rename(ipc_space_t, mach_port_t, mach_port_t); +ipc_object_rename(ipc_space_t, mach_port_name_t, mach_port_name_t); extern void ipc_object_print(ipc_object_t); -- cgit v1.2.3