From 958686efa2175abe3f7044890c2c2370e29147f2 Mon Sep 17 00:00:00 2001 From: Flavio Cruz Date: Wed, 30 Nov 2022 02:14:20 -0500 Subject: Update ipc/ directory to use mach_port_name_t Make it explicit where we use port names versus actual ports. For the 64 bit kernel, port names and ports are of different size so this corrects the syscall arguments and internal structs to have the right size. This patch also uncovered several issues we need to solve to make GNUMach work well on 64 bits. First, the mach_msg call will receive 4 byte port names while the kernel "thinks" they are 8 bytes, which will be a problem. Also, when we send a message, the kernel translates the port names into port pointers in the message copied from user space. This also won't work on 64 bits. In this patch, I added several TODOs to fix the issues later. Message-Id: --- ipc/ipc_right.h | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) (limited to 'ipc/ipc_right.h') diff --git a/ipc/ipc_right.h b/ipc/ipc_right.h index 03642f86..6802abb6 100644 --- a/ipc/ipc_right.h +++ b/ipc/ipc_right.h @@ -44,69 +44,69 @@ #define ipc_right_lookup_read ipc_right_lookup_write extern kern_return_t -ipc_right_lookup_write(ipc_space_t, mach_port_t, ipc_entry_t *); +ipc_right_lookup_write(ipc_space_t, mach_port_name_t, ipc_entry_t *); extern boolean_t ipc_right_reverse(ipc_space_t, ipc_object_t, - mach_port_t *, ipc_entry_t *); + mach_port_name_t *, ipc_entry_t *); extern kern_return_t -ipc_right_dnrequest(ipc_space_t, mach_port_t, boolean_t, +ipc_right_dnrequest(ipc_space_t, mach_port_name_t, boolean_t, ipc_port_t, ipc_port_t *); extern ipc_port_t -ipc_right_dncancel(ipc_space_t, ipc_port_t, mach_port_t, ipc_entry_t); +ipc_right_dncancel(ipc_space_t, ipc_port_t, mach_port_name_t, ipc_entry_t); #define ipc_right_dncancel_macro(space, port, name, entry) \ (((entry)->ie_request == 0) ? IP_NULL : \ ipc_right_dncancel((space), (port), (name), (entry))) extern boolean_t -ipc_right_inuse(ipc_space_t, mach_port_t, ipc_entry_t); +ipc_right_inuse(ipc_space_t, mach_port_name_t, ipc_entry_t); extern boolean_t -ipc_right_check(ipc_space_t, ipc_port_t, mach_port_t, ipc_entry_t); +ipc_right_check(ipc_space_t, ipc_port_t, mach_port_name_t, ipc_entry_t); extern void -ipc_right_clean(ipc_space_t, mach_port_t, ipc_entry_t); +ipc_right_clean(ipc_space_t, mach_port_name_t, ipc_entry_t); extern kern_return_t -ipc_right_destroy(ipc_space_t, mach_port_t, ipc_entry_t); +ipc_right_destroy(ipc_space_t, mach_port_name_t, ipc_entry_t); extern kern_return_t -ipc_right_dealloc(ipc_space_t, mach_port_t, ipc_entry_t); +ipc_right_dealloc(ipc_space_t, mach_port_name_t, ipc_entry_t); extern kern_return_t -ipc_right_delta(ipc_space_t, mach_port_t, ipc_entry_t, +ipc_right_delta(ipc_space_t, mach_port_name_t, ipc_entry_t, mach_port_right_t, mach_port_delta_t); extern kern_return_t -ipc_right_info(ipc_space_t, mach_port_t, ipc_entry_t, +ipc_right_info(ipc_space_t, mach_port_name_t, ipc_entry_t, mach_port_type_t *, mach_port_urefs_t *); extern boolean_t -ipc_right_copyin_check(ipc_space_t, mach_port_t, ipc_entry_t, +ipc_right_copyin_check(ipc_space_t, mach_port_name_t, ipc_entry_t, mach_msg_type_name_t); extern kern_return_t -ipc_right_copyin(ipc_space_t, mach_port_t, ipc_entry_t, +ipc_right_copyin(ipc_space_t, mach_port_name_t, ipc_entry_t, mach_msg_type_name_t, boolean_t, ipc_object_t *, ipc_port_t *); extern void -ipc_right_copyin_undo(ipc_space_t, mach_port_t, ipc_entry_t, +ipc_right_copyin_undo(ipc_space_t, mach_port_name_t, ipc_entry_t, mach_msg_type_name_t, ipc_object_t, ipc_port_t); extern kern_return_t -ipc_right_copyin_two(ipc_space_t, mach_port_t, ipc_entry_t, +ipc_right_copyin_two(ipc_space_t, mach_port_name_t, ipc_entry_t, ipc_object_t *, ipc_port_t *); extern kern_return_t -ipc_right_copyout(ipc_space_t, mach_port_t, ipc_entry_t, +ipc_right_copyout(ipc_space_t, mach_port_name_t, ipc_entry_t, mach_msg_type_name_t, boolean_t, ipc_object_t); extern kern_return_t -ipc_right_rename(ipc_space_t, mach_port_t, ipc_entry_t, - mach_port_t, ipc_entry_t); +ipc_right_rename(ipc_space_t, mach_port_name_t, ipc_entry_t, + mach_port_name_t, ipc_entry_t); #endif /* _IPC_IPC_RIGHT_H_ */ -- cgit v1.2.3