| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
function declarations.
Most of the changes land in one of these buckets:
* Removed unused declarations.
* Used (void) to represent no parameters instead of () which means an
undeterminate number of parameters.
* Included missing header files whenever necessary (stdlib.h,
sys/mman.h, etc)
* Typedefed function pointers to be able to fully declare the parameter
types.
* Added declarations of library functions that are used elsewhere
(example is libps/ps.h).
* Made functions static whenever they are only used in that file.
* Forwarded declarations of some methods that were made static.
Message-Id: <ZDD1o7/tVYeZew+G@jupiter.tail36e24.ts.net>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Newer gcc toolchains tend to enable as-needed by default, so runtime
detection of libcrypt will fail. We can just explicitly link against
libcrypt anyway.
* configure.ac: Check for `crypt()' in libcrypt.
* config.make.in: Substitute HAVE_LIBCRYPT.
* libshouldbeinlibc/idvec-verify.c: Include <crypt.h> only when libcrypt
is available. Replace weak reference with explicit call and fallback
macro.
* utils/x.c: Likewise.
* libshouldbeinlibc/Makefile (LDLIBS): Add -lcrypt when libcrypt is
available.
|
|
|
|
|
| |
Our variants print stack traces on failures. This will make locating
errors much easier.
|
|
|
|
|
|
|
|
|
|
|
|
| |
The getpwnam_r and similar functions only return non-zero on error, but not
finding the given name/UID/GID does not count as an error. When they return 0,
the value of the result (*result when looking at the arguments in the man pages)
still needs to be checked for null.
* libshouldbeinlibc/idvec-rep.c (lookup_uid): Check result for null.
(lookup_gid): Likewise.
* libshouldbeinlibc/idvec-verify.c (verify_passwd): Likewise.
(verify_id): Likewise.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* exec-reauth.c (exec_reauth): Change type of temp var i to
unsigned int to address gcc warning.
* idvec-impgids.c (idvec_merge_implied_gids) Change type of
temp var i to unsigned int to address gcc warning.
* idvec-impgids.c (idvec_merge_implied_gids): Change type of
temp var i to unsigned int to address gcc warning.
* idvec-rep.c (idvec_rep): Change type of temp var i to unsigned
int to address gcc warning.
* idvec-verify (idvec_verify): Change type of temp var i to
unsigned int to address gcc warning.
* idvec.c (idvec_merge_ids, idvec_remove): Change type of temp
var i to unsigned int to address gcc warning.
* portxlate.c (port_name_xlator_create, port_name_xlator_free):
Change type of temp var i to unsigned int to address gcc warning.
* timefmt.c (fmt_seconds): Cast width to int in test to modify
frac_places to address gcc warning.
* (ugids_verify_make_auth): Change type of temp var i to unsigned
int to address gcc warning.
|
| |
|
|
|
|
|
|
| |
* idvec-verify.c (verify_id): Compare id to (uid_t) -1 instead of
checking that is is positive or nul (which is always true).
Reported by Marc-Olivier Mercier <mercier.m@sympatico.ca>.
|
| |
|
|
|
|
|
| |
* idvec-verify.c: Remove #pragma weak crypt.
(verify_passwd): Don't check if crypt exist.
|
|
|
|
|
| |
* idvec-verify.c: Include <crypt.h>.
(crypt): Removed prototype.
|
|
|
|
| |
* idvec-verify.c (verify_passwd): Cast to intptr_t before int.
|
|
|
|
|
|
|
|
|
|
| |
* idvec-verify.c (SHADOW_PASSWORD_STRING): New macro.
(verify_id): Check for shadow password immediately after getpwuid_r
call, and replace PW->pw_passwd pointer with SP->sp_pwdp.
This is ok since the only use will be later in the function,
and we give the lookup buffer function scope.
(verify_passwd): Don't call CHECK_SHADOW for main passwd,
only when rechecking for wheel-group hack.
|
|
|
|
|
| |
* idvec-verify.c (verify_passwd): Avoid nonreentrant getpwuid.
If pw_passwd is "x", use getspnam_r and use its sp_pwdp if it succeeds.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* ugids-verify-auth.c: Include <hurd/password.h> again and remove
temporary definitions of password_check_user and
password_check_group.
1998-11-29 Mark Kettenis <kettenis@phys.uva.nl>
* idvec-verify.c (verify_passwd): Grant access when the password
in the passwd DB is empty.
(verify_id): Also call verify_fn when the password in the password
DB is empty.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change type of GETPASS_FN arg.
Add GETPASS_HOOK, VERIFY_FN, and VERIFY_HOOK args.
Remove WHEEL_UID arg.
Use VERIFY_FN & VERIFY_HOOK instead of doing password comparison ourselves.
(verify_passwd, get_passwd):
New functions.
(idvec_verify):
Change type of GETPASS_FN arg.
Add GETPASS_HOOK, VERIFY_FN, and VERIFY_HOOK args & use them.
|
|
|
|
| |
Fix detection of multiple ids.
|
|
|