From 944cfdbe6cff4e8025a730228b48c1a21b4a2e33 Mon Sep 17 00:00:00 2001
From: Justus Winter <4winter@informatik.uni-hamburg.de>
Date: Tue, 10 Jun 2014 14:22:31 +0200
Subject: libdiskfs: add permission check to file_chflags

Only root is allowed to change the high 16 bits.  The TODO entry says
otherwise, but that must be a mistake.  For reference, see the glibc
sources, sysdeps/mach/hurd/bits/stat.h.

* libdiskfs/file-chflags.c (diskfs_S_file_chflags): Add permission
check.
* TODO (libdiskfs): Remove entry.
---
 TODO | 2 --
 1 file changed, 2 deletions(-)

(limited to 'TODO')

diff --git a/TODO b/TODO
index d2500dc3..0387e9f3 100644
--- a/TODO
+++ b/TODO
@@ -108,8 +108,6 @@ See `tasks', the exported task list.
    Rename the rest to libhurdutil or somesuch.
 
 ** libdiskfs
-*** file_chflags does not do proper permission checking (non-root isn't
-    supposed to be able to change the low bits)
 *** Add the short-circuited-but-not-builtin translator startup code from
     dir-lookup to fsys_getroot.  Compare and match carefully these two
     routines and then share common code.
-- 
cgit v1.2.3