From 61d5aee1ce02888e78eab4ed85a9c8e631006d7b Mon Sep 17 00:00:00 2001 From: Justus Winter Date: Tue, 22 Aug 2017 19:38:25 +0200 Subject: eth-multiplexer: Respect interfaces up flags. * eth-multiplexer/device_impl.c (ds_device_write): Deny writes when interface is down. * eth-multiplexer/vdev.c (add_vdev): Initialize flags to a sane value. (broadcast_pack): Skip interfaces that are down. (broadcast_msg): Likewise. --- eth-multiplexer/vdev.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) (limited to 'eth-multiplexer/vdev.c') diff --git a/eth-multiplexer/vdev.c b/eth-multiplexer/vdev.c index 47dc8d2d..9a1f7b2e 100644 --- a/eth-multiplexer/vdev.c +++ b/eth-multiplexer/vdev.c @@ -145,7 +145,12 @@ add_vdev (char *name, int size, vdev->if_mtu = ETH_MTU; vdev->if_header_format = HDR_ETHERNET; vdev->if_address_size = ETH_ALEN; - vdev->if_flags = 0; + vdev->if_flags = (/* The interface is 'UP' on creation. */ + IFF_UP + /* We have allocated resources for it. */ + | IFF_RUNNING + /* Advertise ethernet-style capabilities. */ + | IFF_BROADCAST | IFF_MULTICAST); /* Compute a pseudo-random but stable ethernet address. */ vdev->if_address[0] = 0x52; @@ -203,8 +208,12 @@ broadcast_pack (char *data, int datalen, struct vether_device *from_vdev) { int internal_deliver_pack (struct vether_device *vdev) { + /* Skip current interface. */ if (from_vdev == vdev) return 0; + /* Skip interfaces that are down. */ + if ((vdev->if_flags & IFF_UP) == 0) + return 0; return deliver_pack (data, datalen, vdev); } @@ -247,6 +256,9 @@ broadcast_msg (struct net_rcv_msg *msg) int internal_deliver_msg (struct vether_device *vdev) { + /* Skip interfaces that are down. */ + if ((vdev->if_flags & IFF_UP) == 0) + return 0; return deliver_msg (msg, vdev); } -- cgit v1.2.3