From 059f34b91f705a7451491068668fedab07ee3a24 Mon Sep 17 00:00:00 2001 From: Richard Braun Date: Fri, 6 Jan 2017 20:56:01 +0100 Subject: ext2fs: minor cleanup Fix some typos, types, add a few checks against integer overflows. ext2fs/inode.c (diskfs_user_read_node): Initialize datalen to 0. (diskfs_set_translator): Fix typo. (diskfs_get_translator): Change datalen type to size_t. * ext2fs/xattr.c (xattr_entry_get): Change type of block parameter to void *. (xattr_entry_create): Guard against integer overflows. (xattr_entry_replace): Likewise. (ext2_set_xattr): Fix typo. --- ext2fs/inode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'ext2fs/inode.c') diff --git a/ext2fs/inode.c b/ext2fs/inode.c index 58edb501..fe163ae1 100644 --- a/ext2fs/inode.c +++ b/ext2fs/inode.c @@ -172,7 +172,7 @@ diskfs_user_read_node (struct node *np, struct lookup_context *ctx) st->st_mode |= S_IPTRANS; else { - size_t datalen; + size_t datalen = 0; err = ext2_get_xattr (np, "gnu.translator", NULL, &datalen); if (! err && datalen > 0) st->st_mode |= S_IPTRANS; @@ -619,7 +619,7 @@ diskfs_set_translator (struct node *np, const char *name, unsigned namelen, } else { - /* Use legacy translator record when xattr is no supported */ + /* Use legacy translator record when xattr is not supported */ daddr_t blkno; struct ext2_inode *di; char buf[block_size]; @@ -696,7 +696,7 @@ diskfs_get_translator (struct node *np, char **namep, unsigned *namelen) { error_t err = 0; daddr_t blkno; - int datalen; + size_t datalen; void *transloc; struct ext2_inode *di; -- cgit v1.2.3