From 8451b436124bd7fdf9c907ebb24687dec10e12bf Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sun, 20 Dec 2009 15:28:17 +0100 Subject: Fix port leak when directly calling MIG stubs * auth/auth.c (S_auth_server_authenticate): Check result of auth_server_authenticate_reply stub. * init/init.c (S_msg_sig_post_untraced): Check result of msg_sig_post_untraced_reply (S_msg_sig_post): Check result of msg_sig_post_reply. --- init/init.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) (limited to 'init/init.c') diff --git a/init/init.c b/init/init.c index d66bee0b..46457293 100644 --- a/init/init.c +++ b/init/init.c @@ -1353,12 +1353,16 @@ S_msg_sig_post_untraced (mach_port_t msgport, mach_port_t reply, mach_msg_type_name_t reply_type, int signo, natural_t sigcode, mach_port_t refport) { + kern_return_t err; + if (refport != mach_task_self ()) return EPERM; mach_port_deallocate (mach_task_self (), refport); /* Reply immediately */ - msg_sig_post_untraced_reply (reply, reply_type, 0); + err = msg_sig_post_untraced_reply (reply, reply_type, 0); + if (err) + return err; process_signal (signo); return MIG_NO_REPLY; @@ -1369,12 +1373,16 @@ S_msg_sig_post (mach_port_t msgport, mach_port_t reply, mach_msg_type_name_t reply_type, int signo, natural_t sigcode, mach_port_t refport) { + kern_return_t err; + if (refport != mach_task_self ()) return EPERM; mach_port_deallocate (mach_task_self (), refport); /* Reply immediately */ - msg_sig_post_reply (reply, reply_type, 0); + err = msg_sig_post_reply (reply, reply_type, 0); + if (err) + return err; process_signal (signo); return MIG_NO_REPLY; -- cgit v1.2.3