From bd7e7ae44c78bcfe623dec8636375685c8c30be3 Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sun, 11 Oct 2015 22:02:41 +0200 Subject: Drop duplicate port deallocation Follow-up dbfa8a3 * libnetfs/io-reauthenticate.c (netfs_S_io_reauthenticate): Do not deallocate parameter port `rend_port' when an error will be returned. * libtrivfs/io-reauthenticate.c (trivfs_S_io_reauthenticate): Do not deallocate parameter port `rend_port' when an error will be returned. --- libnetfs/io-reauthenticate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'libnetfs/io-reauthenticate.c') diff --git a/libnetfs/io-reauthenticate.c b/libnetfs/io-reauthenticate.c index f4f50d52..91928130 100644 --- a/libnetfs/io-reauthenticate.c +++ b/libnetfs/io-reauthenticate.c @@ -43,7 +43,8 @@ netfs_S_io_reauthenticate (struct protid *user, mach_port_t rend_port) newright, 1); pthread_mutex_lock (&user->po->np->lock); - mach_port_deallocate (mach_task_self (), rend_port); + if (!err) + mach_port_deallocate (mach_task_self (), rend_port); mach_port_deallocate (mach_task_self (), newright); mach_port_move_member (mach_task_self (), newpi->pi.port_right, -- cgit v1.2.3