From 524e2fb5a031f1d7bee74abbd270ddbc8e1e334f Mon Sep 17 00:00:00 2001 From: Joan Lledó Date: Sat, 11 May 2019 11:32:02 +0200 Subject: lwip: Fix bug: Error handling on configure_device() * lwip/lwip-util.c: * EINVAL was never being returned. * Return error code for tcpip_callback() as errno. Message-Id: <20190511093202.9763-2-jlledom@member.fsf.org> --- lwip/lwip-util.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'lwip/lwip-util.c') diff --git a/lwip/lwip-util.c b/lwip/lwip-util.c index 4f632185..61f3194a 100644 --- a/lwip/lwip-util.c +++ b/lwip/lwip-util.c @@ -253,7 +253,7 @@ static void update_if (void *arg) { int i; - struct update_if_args *args = (struct update_if_args *) arg; + struct update_if_args *args = arg; netif_set_addr (args->netif, (ip4_addr_t *) & args->addr, (ip4_addr_t *) & args->netmask, @@ -356,10 +356,8 @@ configure_device (struct netif *netif, uint32_t addr, uint32_t netmask, arg->gateway = gateway; arg->addr6 = addr6; arg->addr6_prefix_len = addr6_prefix_len; - err = tcpip_callback (update_if, arg); - if (err) - return err; + err = err_to_errno(tcpip_callback (update_if, arg)); } - return errno; + return err; } -- cgit v1.2.3