From c49ab7f2bee8f4452a7230367abc669fd4baa08b Mon Sep 17 00:00:00 2001
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date: Sun, 1 Jan 2023 12:26:16 +0100
Subject: pflocal: Avoid setting sock fields on error

---
 pflocal/pf.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

(limited to 'pflocal/pf.c')

diff --git a/pflocal/pf.c b/pflocal/pf.c
index 37787f91..290c0b3f 100644
--- a/pflocal/pf.c
+++ b/pflocal/pf.c
@@ -79,10 +79,13 @@ S_socket_create (trivfs_protid_t pf,
 	*port_type = MACH_MSG_TYPE_MAKE_SEND;
     }
 
-  if (pf->user->uids->num > 0)
-    sock->uid = pf->user->uids->ids[0];
-  if (pf->user->gids->num > 0)
-    sock->gid = pf->user->gids->ids[0];
+  if (!err)
+    {
+      if (pf->user->uids->num > 0)
+	sock->uid = pf->user->uids->ids[0];
+      if (pf->user->gids->num > 0)
+	sock->gid = pf->user->gids->ids[0];
+    }
   
   return err;
 }
-- 
cgit v1.2.3