From 4cb90fceb779dbf33cfd9bcf28c66ffc737537f2 Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Sat, 4 Jun 2016 23:14:46 +0200 Subject: Do not make io_select return errors on unsupported READ/WRITE mode The descriptor is valid, it is just the mode which is not available. * console-client/kbd-repeat.c (repeater_select): Drop SELECT_URG flag from `type'. Return 0 instead of EINVAL if `type' contains SELECT_WRITE. * console-client/pc-mouse (repeater_select): Likewise. * trans/mtab.c (trivfs_S_io_select): Return 0 instead of EBADF when the openmodes do not match the requested modes in `type'. * trans/new-fifo.c (io_select_common): Likewise. * trans/fifo.c (io_select_common): Likewise. * trans/null.c (trivfs_S_io_select): Likewise. * trans/streamio.c (io_select_common): Likewise. --- trans/null.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'trans/null.c') diff --git a/trans/null.c b/trans/null.c index bd082dc8..92717ed8 100644 --- a/trans/null.c +++ b/trans/null.c @@ -204,11 +204,7 @@ trivfs_S_io_select (struct trivfs_protid *cred, { if (!cred) return EOPNOTSUPP; - else if (((*type & SELECT_READ) && !(cred->po->openmodes & O_READ)) - || ((*type & SELECT_WRITE) && !(cred->po->openmodes & O_WRITE))) - return EBADF; - else - *type &= ~SELECT_URG; + *type &= ~SELECT_URG; return 0; } -- cgit v1.2.3