diff options
| author | Andrew G. Morgan <morgan@kernel.org> | 2001-10-12 06:13:10 +0000 |
|---|---|---|
| committer | Andrew G. Morgan <morgan@kernel.org> | 2001-10-12 06:13:10 +0000 |
| commit | 47c5c31a6ceb6abe8b406eb74d87aa429c3b93ea (patch) | |
| tree | bf9ac7ab982ac91da3a485e161ac8981c4bdabaf /modules/pam_env | |
| parent | 094652b733bf2422420213c4e87af920ff05e6f3 (diff) | |
| download | pam-47c5c31a6ceb6abe8b406eb74d87aa429c3b93ea.tar.gz pam-47c5c31a6ceb6abe8b406eb74d87aa429c3b93ea.tar.bz2 pam-47c5c31a6ceb6abe8b406eb74d87aa429c3b93ea.zip | |
Relevant BUGIDs: 435991
Purpose of commit: bugfix
Commit summary:
---------------
use strncpy, and even then remember to nul terminate. Courtesy of Harald Welte.
Diffstat (limited to 'modules/pam_env')
| -rw-r--r-- | modules/pam_env/pam_env.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/modules/pam_env/pam_env.c b/modules/pam_env/pam_env.c index f140f3cb..52e54490 100644 --- a/modules/pam_env/pam_env.c +++ b/modules/pam_env/pam_env.c @@ -588,7 +588,8 @@ static int _expand_arg(pam_handle_t *pamh, char **value) _log_err(LOG_ERR, "Unterminated expandable variable: <%s>", orig-2); return PAM_ABORT; } - strncpy(tmpval, orig, (size_t) BUF_SIZE); + strncpy(tmpval, orig, sizeof(tmpval)); + tmpval[sizeof(tmpval)-1] = '\0'; orig=ptr; /* * so, we know we need to expand tmpval, it is either |