diff options
| author | Dmitry V. Levin <ldv@strace.io> | 2024-01-07 08:00:00 +0000 |
|---|---|---|
| committer | Dmitry V. Levin <ldv@strace.io> | 2024-01-13 08:00:00 +0000 |
| commit | 74d724859d4d7ff1119543d77c990a95df96f317 (patch) | |
| tree | 5a0ac81f65fd3d89425cc836eff5333cbab25e40 /modules/pam_listfile | |
| parent | 2894abec4d2bf487348994f1703671a5e039c0f9 (diff) | |
| download | pam-74d724859d4d7ff1119543d77c990a95df96f317.tar.gz pam-74d724859d4d7ff1119543d77c990a95df96f317.tar.bz2 pam-74d724859d4d7ff1119543d77c990a95df96f317.zip | |
pam_listfile: consistently log unknown options
In most cases the parser of module options already logs unknown options
before returning, but in two cases it didn't.
* modules/pam_listfile/pam_listfile.c (pam_sm_authenticate): Log unknown
onerr= and sense= options.
Diffstat (limited to 'modules/pam_listfile')
| -rw-r--r-- | modules/pam_listfile/pam_listfile.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/modules/pam_listfile/pam_listfile.c b/modules/pam_listfile/pam_listfile.c index 509320c7..bbfb46fd 100644 --- a/modules/pam_listfile/pam_listfile.c +++ b/modules/pam_listfile/pam_listfile.c @@ -83,15 +83,19 @@ pam_sm_authenticate (pam_handle_t *pamh, int flags UNUSED, onerr = PAM_SUCCESS; else if(!strcmp(str,"fail")) onerr = PAM_SERVICE_ERR; - else + else { + pam_syslog(pamh, LOG_ERR, "Unknown option: %s", argv[i]); return PAM_SERVICE_ERR; + } } else if ((str = pam_str_skip_prefix(argv[i], "sense=")) != NULL) { if(!strcmp(str,"allow")) sense=0; else if(!strcmp(str,"deny")) sense=1; - else + else { + pam_syslog(pamh, LOG_ERR, "Unknown option: %s", argv[i]); return onerr; + } } else if ((str = pam_str_skip_prefix(argv[i], "file=")) != NULL) { ifname = str; } else if ((str = pam_str_skip_prefix(argv[i], "item=")) != NULL) { |