Fix -Wcast-align compilation warnings on arm

Apparently, gcc is also not smart enough to infer the alignment
of structure fields, for details see
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89133

Use unions to avoid these casts altogether, this fixes compilation
warnings reported by gcc on arm, e.g.:

md5.c: In function 'MD5Update':
md5.c:92:35: error: cast increases required alignment of target type [-Werror=cast-align]
   92 |   MD5Name(MD5Transform)(ctx->buf, (uint32 *) ctx->in);
      |                                   ^
md5.c:101:35: error: cast increases required alignment of target type [-Werror=cast-align]
  101 |   MD5Name(MD5Transform)(ctx->buf, (uint32 *) ctx->in);
      |                                   ^
md5.c: In function 'MD5Final':
md5.c:136:35: error: cast increases required alignment of target type [-Werror=cast-align]
  136 |   MD5Name(MD5Transform)(ctx->buf, (uint32 *) ctx->in);
      |                                   ^
md5.c:147:9: error: cast increases required alignment of target type [-Werror=cast-align]
  147 |  memcpy((uint32 *)ctx->in + 14, ctx->bits, 2*sizeof(uint32));
      |         ^
md5.c:149:34: error: cast increases required alignment of target type [-Werror=cast-align]
  149 |  MD5Name(MD5Transform)(ctx->buf, (uint32 *) ctx->in);
      |                                  ^

* modules/pam_namespace/md5.h (struct MD5Context): Replace "buf" and
"in" fields with unions.  All users updated.
* modules/pam_unix/md5.h (struct MD5Context): Likewise.
* modules/pam_timestamp/sha1.h (struct sha1_context.pending): Replace
with a union.  All users updated.

Complements: v1.4.0~195 ("Fix most of clang -Wcast-align compilation warnings")

1 files changed, 4 insertions, 1 deletions

diff --git a/modules/pam_timestamp/sha1.h b/modules/pam_timestamp/sha1.h
index a1c38917..69f432e6 100644
--- a/modules/pam_timestamp/sha1.h
+++ b/modules/pam_timestamp/sha1.h
@@ -46,7 +46,10 @@
 
 struct sha1_context {
 	size_t count;
-	unsigned char pending[SHA1_BLOCK_SIZE] PAM_ATTRIBUTE_ALIGNED(4);
+	union {
+		unsigned char c[SHA1_BLOCK_SIZE];
+		uint32_t i[SHA1_BLOCK_SIZE / sizeof(uint32_t)];
+	} pending;
 	uint32_t counts[2];
 	size_t pending_count;
 	uint32_t a, b, c, d, e;