aboutsummaryrefslogtreecommitdiff
path: root/modules/pam_unix/passverify.c
diff options
context:
space:
mode:
authorChristian Göttsche <cgzones@googlemail.com>2024-01-04 18:24:05 +0100
committerDmitry V. Levin <ldv@strace.io>2024-01-15 20:01:23 +0000
commitd5c01cfd6e47503fb597c5568f43cdf079a30719 (patch)
tree66a50558ea70bd15435df02e57d4ce4de496c80e /modules/pam_unix/passverify.c
parent05d50c9f29ef1a1c897feb604c0595142840a93e (diff)
downloadpam-d5c01cfd6e47503fb597c5568f43cdf079a30719.tar.gz
pam-d5c01cfd6e47503fb597c5568f43cdf079a30719.tar.bz2
pam-d5c01cfd6e47503fb597c5568f43cdf079a30719.zip
pam_unix: clean additional possible sensitive buffers
Diffstat (limited to 'modules/pam_unix/passverify.c')
-rw-r--r--modules/pam_unix/passverify.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/modules/pam_unix/passverify.c b/modules/pam_unix/passverify.c
index 2c95bba2..426d4028 100644
--- a/modules/pam_unix/passverify.c
+++ b/modules/pam_unix/passverify.c
@@ -729,7 +729,7 @@ save_old_password(pam_handle_t *pamh, const char *forwho, const char *oldpass,
goto done;
}
- while (getline(&buf, &bufsize, opwfile) != -1) {
+ for (; getline(&buf, &bufsize, opwfile) != -1; pam_overwrite_n(buf, bufsize)) {
if (!strncmp(buf, forwho, len) && strchr(":,\n", buf[len]) != NULL) {
char *ep, *sptr = NULL;
long value;
@@ -779,6 +779,7 @@ save_old_password(pam_handle_t *pamh, const char *forwho, const char *oldpass,
break;
}
}
+ pam_overwrite_n(buf, bufsize);
free(buf);
fclose(opwfile);