aboutsummaryrefslogtreecommitdiff
path: root/modules/pam_userdb
diff options
context:
space:
mode:
authorChristian Göttsche <cgzones@googlemail.com>2024-01-16 15:12:58 +0100
committerDmitry V. Levin <ldv@strace.io>2024-01-21 08:00:00 +0000
commit0e80c788850c4a699e4bfb3ab7b44e354b8fdfd7 (patch)
tree854b6c8e6b0c3c5e99d604efb5b1e381b5fd915a /modules/pam_userdb
parent63476f211a8c02bcd24786a1373012d1831774ec (diff)
downloadpam-0e80c788850c4a699e4bfb3ab7b44e354b8fdfd7.tar.gz
pam-0e80c788850c4a699e4bfb3ab7b44e354b8fdfd7.tar.bz2
pam-0e80c788850c4a699e4bfb3ab7b44e354b8fdfd7.zip
modules: zero out crypt_r(3) data before usage
The manual page of crypt_r(3) recommends to zero the entire data object.
Diffstat (limited to 'modules/pam_userdb')
-rw-r--r--modules/pam_userdb/pam_userdb.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/modules/pam_userdb/pam_userdb.c b/modules/pam_userdb/pam_userdb.c
index 0b5e5965..7e1407f4 100644
--- a/modules/pam_userdb/pam_userdb.c
+++ b/modules/pam_userdb/pam_userdb.c
@@ -287,11 +287,10 @@ user_lookup (pam_handle_t *pamh, const char *database, const char *cryptmode,
} else {
#ifdef HAVE_CRYPT_R
struct crypt_data *cdata = NULL;
- cdata = malloc(sizeof(*cdata));
+ cdata = calloc(1, sizeof(*cdata));
if (cdata == NULL) {
pam_syslog(pamh, LOG_CRIT, "malloc failed: struct crypt_data");
} else {
- cdata->initialized = 0;
cryptpw = crypt_r(pass, pwhash, cdata);
}
#else