diff options
| author | Tobias Stoeckmann <tobias@stoeckmann.org> | 2023-12-15 10:14:11 +0100 |
|---|---|---|
| committer | Dmitry V. Levin <ldv@strace.io> | 2023-12-19 12:22:59 +0000 |
| commit | c2fafe1be0fb72aa1bd521efe2f524074bf143c7 (patch) | |
| tree | 0790beda071109b1c0ef9397d442ff641f7077c9 /modules | |
| parent | 6834e0dd1dcae917caa464d1fe124c2f6c6116f4 (diff) | |
| download | pam-c2fafe1be0fb72aa1bd521efe2f524074bf143c7.tar.gz pam-c2fafe1be0fb72aa1bd521efe2f524074bf143c7.tar.bz2 pam-c2fafe1be0fb72aa1bd521efe2f524074bf143c7.zip | |
treewide: replace malloc followed by strcpy with strdup
Suggested-by: Benny Baumann <BenBE@geshi.org>
Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
Diffstat (limited to 'modules')
| -rw-r--r-- | modules/pam_listfile/pam_listfile.c | 3 | ||||
| -rw-r--r-- | modules/pam_namespace/pam_namespace.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/modules/pam_listfile/pam_listfile.c b/modules/pam_listfile/pam_listfile.c index a01b5a8a..3e6a7092 100644 --- a/modules/pam_listfile/pam_listfile.c +++ b/modules/pam_listfile/pam_listfile.c @@ -106,10 +106,9 @@ pam_sm_authenticate (pam_handle_t *pamh, int flags UNUSED, } else if(!strcmp(mybuf,"file")) { free(ifname); - ifname = malloc(strlen(myval)+1); + ifname = strdup(myval); if (!ifname) return PAM_BUF_ERR; - strcpy(ifname,myval); } else if(!strcmp(mybuf,"item")) if(!strcmp(myval,"user")) citem = PAM_USER; diff --git a/modules/pam_namespace/pam_namespace.c b/modules/pam_namespace/pam_namespace.c index 6937b6ac..d78111b3 100644 --- a/modules/pam_namespace/pam_namespace.c +++ b/modules/pam_namespace/pam_namespace.c @@ -1295,13 +1295,12 @@ static int check_inst_parent(char *ipath, struct instance_data *idata) * admin explicitly instructs to ignore the instance parent * mode by the "ignore_instance_parent_mode" argument). */ - inst_parent = malloc(strlen(ipath)+1); + inst_parent = strdup(ipath); if (!inst_parent) { pam_syslog(idata->pamh, LOG_CRIT, "Error allocating pathname string"); return PAM_SESSION_ERR; } - strcpy(inst_parent, ipath); trailing_slash = strrchr(inst_parent, '/'); if (trailing_slash) *trailing_slash = '\0'; |