From c2fafe1be0fb72aa1bd521efe2f524074bf143c7 Mon Sep 17 00:00:00 2001 From: Tobias Stoeckmann Date: Fri, 15 Dec 2023 10:14:11 +0100 Subject: treewide: replace malloc followed by strcpy with strdup Suggested-by: Benny Baumann Signed-off-by: Tobias Stoeckmann --- libpam/pam_misc.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'libpam') diff --git a/libpam/pam_misc.c b/libpam/pam_misc.c index a843ebc7..721b36f3 100644 --- a/libpam/pam_misc.c +++ b/libpam/pam_misc.c @@ -116,14 +116,8 @@ char *_pam_strdup(const char *x) register char *new=NULL; if (x != NULL) { - register size_t len; - - len = strlen (x) + 1; /* length of string including NUL */ - if ((new = malloc(len)) == NULL) { - len = 0; + if ((new = strdup(x)) == NULL) { pam_syslog(NULL, LOG_CRIT, "_pam_strdup: failed to get memory"); - } else { - strcpy (new, x); } x = NULL; } -- cgit v1.2.3