From 4020ca8c0fe3ac88eccc5c62aa8d8c63a4043578 Mon Sep 17 00:00:00 2001 From: Christian Göttsche Date: Mon, 7 Aug 2023 12:46:33 +0200 Subject: libpamc: cast to unsigned char for character handling function Character handling functions, like isspace(3), expect a value representable as unsigned char or equal to EOF. Otherwise the behavior is undefined. See https://wiki.sei.cmu.edu/confluence/display/c/STR37-C.+Arguments+to+character-handling+functions+must+be+representable+as+an+unsigned+char --- libpamc/pamc_load.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libpamc') diff --git a/libpamc/pamc_load.c b/libpamc/pamc_load.c index b4fa78b3..69fb8b87 100644 --- a/libpamc/pamc_load.c +++ b/libpamc/pamc_load.c @@ -324,7 +324,7 @@ int __pamc_valid_agent_id(int id_length, const char *id) for (i=post=0 ; i < id_length; ++i) { int ch = id[i++]; - if (isalpha(ch) || isdigit(ch) || (ch == '_')) { + if (isalpha((unsigned char)ch) || isdigit((unsigned char)ch) || (ch == '_')) { continue; } else if (post && (ch == '.')) { continue; -- cgit v1.2.3