From 4f0cf2eb43c73080789579f060a327d3d90fb0dc Mon Sep 17 00:00:00 2001 From: Christian Göttsche Date: Thu, 4 Jan 2024 17:46:46 +0100 Subject: libpamc/test: fix assignment Assign the error code instead of performing a no-op comparison. Reported by cppcheck. --- libpamc/test/modules/pam_secret.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libpamc') diff --git a/libpamc/test/modules/pam_secret.c b/libpamc/test/modules/pam_secret.c index 12215359..da607b1f 100644 --- a/libpamc/test/modules/pam_secret.c +++ b/libpamc/test/modules/pam_secret.c @@ -166,7 +166,7 @@ static int converse(pam_handle_t *pamh, struct ps_state_s *new) retval = conv->conv(1, &msg_ptr, &single_reply, conv->appdata_ptr); if (retval == PAM_SUCCESS) { if ((single_reply == NULL) || (single_reply->resp == NULL)) { - retval == PAM_CONV_ERR; + retval = PAM_CONV_ERR; } else { new->current_reply = (pamc_bp_t) single_reply->resp; single_reply->resp = NULL; -- cgit v1.2.3