From 81e74d598b080de5c6a66585ebf2a9d6d1186f00 Mon Sep 17 00:00:00 2001 From: Christian Göttsche Date: Wed, 8 Feb 2023 18:07:59 +0100 Subject: pam_env: override undefined pointer after asprintf failure On failure the content of the string pointer passed to asprintf(3) is undefined. Set to NULL before free'ing the parent array. --- modules/pam_env/pam_env.c | 1 + 1 file changed, 1 insertion(+) (limited to 'modules/pam_env') diff --git a/modules/pam_env/pam_env.c b/modules/pam_env/pam_env.c index a25e195b..2868cfce 100644 --- a/modules/pam_env/pam_env.c +++ b/modules/pam_env/pam_env.c @@ -265,6 +265,7 @@ econf_read_file(const pam_handle_t *pamh, const char *filename, const char *deli pam_syslog(pamh, LOG_ERR, "Cannot allocate memory."); econf_free(keys); econf_freeFile(key_file); + (*lines)[i] = NULL; free_string_array(*lines); free (val); return PAM_BUF_ERR; -- cgit v1.2.3