From bde2277d2aa1cd9d4a14a1a1f89241d5e86b0bad Mon Sep 17 00:00:00 2001
From: Christian Göttsche <cgzones@googlemail.com>
Date: Sat, 18 Feb 2023 14:22:53 +0100
Subject: pam_env: use helper to free string list

Free the environment variables list via the designated helper
free_string_array() rather than free its elements in a loop, which might
skip some.
---
 modules/pam_env/pam_env.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

(limited to 'modules/pam_env')

diff --git a/modules/pam_env/pam_env.c b/modules/pam_env/pam_env.c
index 2868cfce..42842308 100644
--- a/modules/pam_env/pam_env.c
+++ b/modules/pam_env/pam_env.c
@@ -992,11 +992,10 @@ _parse_env_file(pam_handle_t *pamh, int ctrl, const char *file)
 	    pam_syslog(pamh, LOG_DEBUG,
 		       "pam_putenv(\"%s\")", key);
 	}
-	free(*env);
     }
 
     /* tidy up */
-    free(env_list);
+    free_string_array(env_list);
     D(("Exit."));
     return retval;
 }
-- 
cgit v1.2.3