From 0f65b1fe153b343e28b617a8553b6e978cbd37d4 Mon Sep 17 00:00:00 2001 From: "Dmitry V. Levin" Date: Tue, 19 Nov 2013 14:18:44 +0000 Subject: pam_securetty: check return value of fgets Checking return value of fgets not only silences the warning from glibc but also leads to a cleaner code. * modules/pam_securetty/pam_securetty.c (securetty_perform_check): Check return value of fgets. --- modules/pam_securetty/pam_securetty.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'modules/pam_securetty') diff --git a/modules/pam_securetty/pam_securetty.c b/modules/pam_securetty/pam_securetty.c index 5f2d1bec..04741309 100644 --- a/modules/pam_securetty/pam_securetty.c +++ b/modules/pam_securetty/pam_securetty.c @@ -159,11 +159,10 @@ securetty_perform_check (pam_handle_t *pamh, int ctrl, if (cmdlinefile != NULL) { char line[LINE_MAX], *p; - line[0] = 0; - fgets(line, sizeof(line), cmdlinefile); + p = fgets(line, sizeof(line), cmdlinefile); fclose(cmdlinefile); - for (p = line; p; p = strstr(p+1, "console=")) { + for (; p; p = strstr(p+1, "console=")) { char *e; /* Test whether this is a beginning of a word? */ -- cgit v1.2.3