Merge pull request #50 from crupest/refactor

Refactor : A Huge Step

1 files changed, 10 insertions, 3 deletions

diff --git a/Timeline/Filters/ContentHeaderAttributes.cs b/Timeline/Filters/ContentHeaderAttributes.cs
index 14685a01..e3d4eeb2 100644
--- a/Timeline/Filters/ContentHeaderAttributes.cs
+++ b/Timeline/Filters/ContentHeaderAttributes.cs
@@ -1,16 +1,20 @@
 using Microsoft.AspNetCore.Mvc;

 using Microsoft.AspNetCore.Mvc.Filters;

+using Microsoft.Extensions.DependencyInjection;

+using Microsoft.Extensions.Localization;

 using Timeline.Models.Http;

 

 namespace Timeline.Filters

 {

     public class RequireContentTypeAttribute : ActionFilterAttribute

     {

+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods")]

         public override void OnActionExecuting(ActionExecutingContext context)

         {

             if (context.HttpContext.Request.ContentType == null)

             {

-                context.Result = new BadRequestObjectResult(CommonResponse.MissingContentType());

+                var localizerFactory = context.HttpContext.RequestServices.GetRequiredService<IStringLocalizerFactory>();

+                context.Result = new BadRequestObjectResult(HeaderErrorResponse.MissingContentType(localizerFactory));

             }

         }

     }

@@ -30,17 +34,20 @@ namespace Timeline.Filters
 

         public bool RequireNonZero { get; set; }

 

+        [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods")]

         public override void OnActionExecuting(ActionExecutingContext context)

         {

             if (context.HttpContext.Request.ContentLength == null)

             {

-                context.Result = new BadRequestObjectResult(CommonResponse.MissingContentLength());

+                var localizerFactory = context.HttpContext.RequestServices.GetRequiredService<IStringLocalizerFactory>();

+                context.Result = new BadRequestObjectResult(HeaderErrorResponse.MissingContentLength(localizerFactory));

                 return;

             }

 

             if (RequireNonZero && context.HttpContext.Request.ContentLength.Value == 0)

             {

-                context.Result = new BadRequestObjectResult(CommonResponse.ZeroContentLength());

+                var localizerFactory = context.HttpContext.RequestServices.GetRequiredService<IStringLocalizerFactory>();

+                context.Result = new BadRequestObjectResult(HeaderErrorResponse.ZeroContentLength(localizerFactory));

                 return;

             }

         }