aboutsummaryrefslogtreecommitdiff
path: root/src/platform
diff options
context:
space:
mode:
authorcrupest <crupest@outlook.com>2023-10-14 22:48:16 +0800
committercrupest <crupest@outlook.com>2023-10-14 22:48:16 +0800
commit856df14d749014f11a583ade2fee988b076754cc (patch)
tree5e0684b2a4c01f37ddc6ad869c2c86125e4bb77a /src/platform
parent9ec7c364ce8681305910b728588913f2b11cfbe6 (diff)
downloadcru-856df14d749014f11a583ade2fee988b076754cc.tar.gz
cru-856df14d749014f11a583ade2fee988b076754cc.tar.bz2
cru-856df14d749014f11a583ade2fee988b076754cc.zip
Re-think about ToString.
ToString for a class should lies in the same namespace of the class. Argument-dependent name lookup will help make Format work. The problem is it will hide ToString at parent namespace. But if you call ToString explicitly, it's you duty to use the ToString in correct namespace.
Diffstat (limited to 'src/platform')
-rw-r--r--src/platform/Color.cpp4
-rw-r--r--src/platform/graphics/SvgGeometryBuilderMixin.cpp6
2 files changed, 3 insertions, 7 deletions
diff --git a/src/platform/Color.cpp b/src/platform/Color.cpp
index 81709c6f..a35ef535 100644
--- a/src/platform/Color.cpp
+++ b/src/platform/Color.cpp
@@ -2,13 +2,9 @@
#include <gsl/gsl>
-#include <algorithm>
#include <cmath>
#include <cstdint>
#include <optional>
-#include <stdexcept>
-#include <string>
-#include <string_view>
namespace cru::platform {
String Color::ToString() const {
diff --git a/src/platform/graphics/SvgGeometryBuilderMixin.cpp b/src/platform/graphics/SvgGeometryBuilderMixin.cpp
index 1f868f44..3f8b48ad 100644
--- a/src/platform/graphics/SvgGeometryBuilderMixin.cpp
+++ b/src/platform/graphics/SvgGeometryBuilderMixin.cpp
@@ -108,14 +108,14 @@ void SvgGeometryBuilderMixin::Append(bool flag) {
}
void SvgGeometryBuilderMixin::Append(float number) {
- current_ += ToString(number);
+ current_ += cru::ToString(number);
current_ += u' ';
}
void SvgGeometryBuilderMixin::Append(const Point& point) {
- current_ += ToString(point.x);
+ current_ += cru::ToString(point.x);
current_ += u',';
- current_ += ToString(point.y);
+ current_ += cru::ToString(point.y);
current_ += u' ';
}
} // namespace cru::platform::graphics