diff options
author | Abseil Team <absl-team@google.com> | 2022-10-13 14:12:39 -0700 |
---|---|---|
committer | Copybara-Service <copybara-worker@google.com> | 2022-10-13 14:13:57 -0700 |
commit | f073fe8ee5dcb0aa18c893198747062f2f51ab59 (patch) | |
tree | fa473e3a4a77146484d19b456371452418e4a297 /absl/copts/copts.py | |
parent | cbaba1a9bfdc8900e0d360e87d2fee137f6f7d9e (diff) | |
download | abseil-f073fe8ee5dcb0aa18c893198747062f2f51ab59.tar.gz abseil-f073fe8ee5dcb0aa18c893198747062f2f51ab59.tar.bz2 abseil-f073fe8ee5dcb0aa18c893198747062f2f51ab59.zip |
Fix "unsafe narrowing" warnings in absl, 12/12.
Addresses failures with the following, in some files:
-Wshorten-64-to-32
-Wimplicit-int-conversion
-Wsign-compare
-Wsign-conversion
-Wtautological-unsigned-zero-compare
(This specific CL enables these warnings and fixes the remaining known issues.)
Bug: chromium:1292951
PiperOrigin-RevId: 480981210
Change-Id: I92d5023c6833e24d6aa29b10d433116329972f41
Diffstat (limited to 'absl/copts/copts.py')
-rw-r--r-- | absl/copts/copts.py | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/absl/copts/copts.py b/absl/copts/copts.py index 0d6c1ec3..8281d989 100644 --- a/absl/copts/copts.py +++ b/absl/copts/copts.py @@ -19,13 +19,16 @@ MSVC_BIG_WARNING_FLAGS = [ LLVM_TEST_DISABLE_WARNINGS_FLAGS = [ "-Wno-c99-extensions", "-Wno-deprecated-declarations", + "-Wno-implicit-int-conversion", "-Wno-missing-noreturn", "-Wno-missing-prototypes", "-Wno-missing-variable-declarations", "-Wno-null-conversion", "-Wno-shadow", "-Wno-shift-sign-overflow", + "-Wno-shorten-64-to-32", "-Wno-sign-compare", + "-Wno-sign-conversion", "-Wno-unused-function", "-Wno-unused-member-function", "-Wno-unused-parameter", @@ -96,6 +99,7 @@ COPT_VARS = { "-Wshadow-all", "-Wstring-conversion", "-Wtautological-overlap-compare", + "-Wtautological-unsigned-zero-compare", "-Wundef", "-Wuninitialized", "-Wunreachable-code", @@ -109,9 +113,6 @@ COPT_VARS = { "-Wno-float-conversion", "-Wno-implicit-float-conversion", "-Wno-implicit-int-float-conversion", - "-Wno-implicit-int-conversion", - "-Wno-shorten-64-to-32", - "-Wno-sign-conversion", # Disable warnings on unknown warning flags (when warning flags are # unknown on older compiler versions) "-Wno-unknown-warning-option", |