diff options
| author | Abseil Team <absl-team@google.com> | 2022-07-28 07:45:06 -0700 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2022-07-28 07:46:07 -0700 |
| commit | 7f51ef5ed2740dab2bbf53c4dd5931b6e8ec6a5b (patch) | |
| tree | 72096ff69ed2b4dac6db4e1bcc5d85d3ecb0ef8d /absl/debugging/symbolize_win32.inc | |
| parent | c7e60ccfcd708a73008ed2df040162c66697bc18 (diff) | |
| download | abseil-7f51ef5ed2740dab2bbf53c4dd5931b6e8ec6a5b.tar.gz abseil-7f51ef5ed2740dab2bbf53c4dd5931b6e8ec6a5b.tar.bz2 abseil-7f51ef5ed2740dab2bbf53c4dd5931b6e8ec6a5b.zip | |
Fix "unsafe narrowing" warnings in absl, 1/n.
Addresses failures with the following, in some files:
-Wshorten-64-to-32
-Wimplicit-int-conversion
-Wsign-compare
-Wsign-conversion
-Wtautological-unsigned-zero-compare
(This specific CL focuses on .h and win32 .inc files.)
Bug: chromium:1292951
PiperOrigin-RevId: 463835431
Change-Id: If8e5f7f651d5cd96035e23e4623bdb08a7fedabe
Diffstat (limited to 'absl/debugging/symbolize_win32.inc')
| -rw-r--r-- | absl/debugging/symbolize_win32.inc | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/absl/debugging/symbolize_win32.inc b/absl/debugging/symbolize_win32.inc index c3df46f6..53a099a1 100644 --- a/absl/debugging/symbolize_win32.inc +++ b/absl/debugging/symbolize_win32.inc @@ -65,14 +65,15 @@ bool Symbolize(const void* pc, char* out, int out_size) { if (!SymFromAddr(process, reinterpret_cast<DWORD64>(pc), nullptr, symbol)) { return false; } - strncpy(out, symbol->Name, out_size); - if (out[out_size - 1] != '\0') { + const size_t out_size_t = static_cast<size_t>(out_size); + strncpy(out, symbol->Name, out_size_t); + if (out[out_size_t - 1] != '\0') { // strncpy() does not '\0' terminate when it truncates. static constexpr char kEllipsis[] = "..."; - int ellipsis_size = - std::min<int>(sizeof(kEllipsis) - 1, out_size - 1); - memcpy(out + out_size - ellipsis_size - 1, kEllipsis, ellipsis_size); - out[out_size - 1] = '\0'; + size_t ellipsis_size = + std::min(sizeof(kEllipsis) - 1, out_size_t - 1); + memcpy(out + out_size_t - ellipsis_size - 1, kEllipsis, ellipsis_size); + out[out_size_t - 1] = '\0'; } return true; } |