diff options
| author | Adam Gajda <80600850+adgajda@users.noreply.github.com> | 2024-03-13 13:19:59 -0700 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2024-03-13 13:20:57 -0700 |
| commit | 1c233c55171af9101962ba9a5c2bda7ace18fcfe (patch) | |
| tree | 205d09abada48e61a96071c870037aa64cc0b310 /absl/flags/commandlineflag.h | |
| parent | 2a7d0da1dd6ab149eaa66b5582f0a21a0abc2df4 (diff) | |
| download | abseil-1c233c55171af9101962ba9a5c2bda7ace18fcfe.tar.gz abseil-1c233c55171af9101962ba9a5c2bda7ace18fcfe.tar.bz2 abseil-1c233c55171af9101962ba9a5c2bda7ace18fcfe.zip | |
PR #1603: Disable -Wnon-virtual-dtor warning for CommandLineFlag implementations
Imported from GitHub PR https://github.com/abseil/abseil-cpp/pull/1603
Merge e324303b1f2aaee8e4418cffb838f150a2d4f4e7 into d802708117c6ef6b9783efe499b2a2d0d0536c77
Merging this change closes #1603
COPYBARA_INTEGRATE_REVIEW=https://github.com/abseil/abseil-cpp/pull/1603 from adgajda:master e324303b1f2aaee8e4418cffb838f150a2d4f4e7
PiperOrigin-RevId: 615522811
Change-Id: I46a388ac62ffd42ce175dbfa04e414dd498855f8
Diffstat (limited to 'absl/flags/commandlineflag.h')
| -rw-r--r-- | absl/flags/commandlineflag.h | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/absl/flags/commandlineflag.h b/absl/flags/commandlineflag.h index c30aa609..26ec0e7d 100644 --- a/absl/flags/commandlineflag.h +++ b/absl/flags/commandlineflag.h @@ -59,6 +59,14 @@ class PrivateHandleAccessor; // // Now you can get flag info from that reflection handle. // std::string flag_location = my_flag_data->Filename(); // ... + +// These are only used as constexpr global objects. +// They do not use a virtual destructor to simplify their implementation. +// They are not destroyed except at program exit, so leaks do not matter. +#if defined(__GNUC__) && !defined(__clang__) +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wnon-virtual-dtor" +#endif class CommandLineFlag { public: constexpr CommandLineFlag() = default; @@ -193,6 +201,9 @@ class CommandLineFlag { // flag's value type. virtual void CheckDefaultValueParsingRoundtrip() const = 0; }; +#if defined(__GNUC__) && !defined(__clang__) +#pragma GCC diagnostic pop +#endif ABSL_NAMESPACE_END } // namespace absl |