diff options
| author | Abseil Team <absl-team@google.com> | 2020-05-20 00:23:37 -0700 |
|---|---|---|
| committer | Mark Barolak <mbar@google.com> | 2020-05-21 10:16:55 -0400 |
| commit | cf1a02e2dc5a1bc9d095f4c996306de448ca200f (patch) | |
| tree | 74cd530ed421fb27a8774a5a11243bd81682ee18 /absl/flags/internal/registry.cc | |
| parent | 768eb2ca2857342673fcd462792ce04b8bac3fa3 (diff) | |
| download | abseil-cf1a02e2dc5a1bc9d095f4c996306de448ca200f.tar.gz abseil-cf1a02e2dc5a1bc9d095f4c996306de448ca200f.tar.bz2 abseil-cf1a02e2dc5a1bc9d095f4c996306de448ca200f.zip | |
Export of internal Abseil changes
--
30e5e00a54cabc50118a3e1055826ea02a0d32e4 by Gennadiy Rozental <rogeeff@google.com>:
Move flag help into flag_cold section.
To facilitate this we set flag help not in a constructor, but during flag registration. This allows us to place flag name as static variable inside non constexpr lambda and invoke it immediately in FlagRegistrar argument location.
PiperOrigin-RevId: 312432625
--
efd91b05152b68df648cff5ba38e9669a817c12f by Gennadiy Rozental <rogeeff@google.com>:
Make CommandLineFlag public.
PiperOrigin-RevId: 312404666
--
dc7f5fb73487766fa8a76d6b97d28116e5334445 by Mark Barolak <mbar@google.com>:
Internal change.
PiperOrigin-RevId: 312297164
GitOrigin-RevId: 30e5e00a54cabc50118a3e1055826ea02a0d32e4
Change-Id: Ic46ab011bb804645264572caddff0becba5f9170
Diffstat (limited to 'absl/flags/internal/registry.cc')
| -rw-r--r-- | absl/flags/internal/registry.cc | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/absl/flags/internal/registry.cc b/absl/flags/internal/registry.cc index 3b941f04..70d76557 100644 --- a/absl/flags/internal/registry.cc +++ b/absl/flags/internal/registry.cc @@ -28,7 +28,7 @@ #include "absl/base/config.h" #include "absl/base/internal/raw_logging.h" #include "absl/base/thread_annotations.h" -#include "absl/flags/internal/commandlineflag.h" +#include "absl/flags/commandlineflag.h" #include "absl/flags/internal/private_handle_accessor.h" #include "absl/flags/usage_config.h" #include "absl/strings/str_cat.h" @@ -111,6 +111,7 @@ class FlagRegistryLock { }; void DestroyRetiredFlag(CommandLineFlag* flag); + } // namespace void FlagRegistry::RegisterFlag(CommandLineFlag* flag) { @@ -205,7 +206,7 @@ class FlagSaverImpl { // It's an error to call this more than once. void SaveFromRegistry() { assert(backup_registry_.empty()); // call only once! - flags_internal::ForEachFlag([&](flags_internal::CommandLineFlag* flag) { + flags_internal::ForEachFlag([&](CommandLineFlag* flag) { if (auto flag_state = flags_internal::PrivateHandleAccessor::SaveState(flag)) { backup_registry_.emplace_back(std::move(flag_state)); @@ -283,7 +284,7 @@ bool RegisterCommandLineFlag(CommandLineFlag* flag) { namespace { -class RetiredFlagObj final : public flags_internal::CommandLineFlag { +class RetiredFlagObj final : public CommandLineFlag { public: constexpr RetiredFlagObj(const char* name, FlagFastTypeId type_id) : name_(name), type_id_(type_id) {} @@ -319,7 +320,7 @@ class RetiredFlagObj final : public flags_internal::CommandLineFlag { const FlagFastTypeId type_id_; }; -void DestroyRetiredFlag(flags_internal::CommandLineFlag* flag) { +void DestroyRetiredFlag(CommandLineFlag* flag) { assert(flag->IsRetired()); delete static_cast<RetiredFlagObj*>(flag); } |