diff options
| author | Derek Mauro <dmauro@google.com> | 2024-02-12 09:43:50 -0800 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2024-02-12 09:45:21 -0800 |
| commit | 34604d5b1f6ae14c65b3992478b59f7108051979 (patch) | |
| tree | c17064f78ee073d0c421182bbe3555010b43c25d /absl/numeric | |
| parent | 119e0d3f74733aff2999d39cb8be99ddcb081c66 (diff) | |
| download | abseil-34604d5b1f6ae14c65b3992478b59f7108051979.tar.gz abseil-34604d5b1f6ae14c65b3992478b59f7108051979.tar.bz2 abseil-34604d5b1f6ae14c65b3992478b59f7108051979.zip | |
Remove deprecated symbol absl::kuint128max
absl::kuint128max should be replaced with absl::Uint128Max()
PiperOrigin-RevId: 606279299
Change-Id: Ib67b5431f14891f56bb706e62f183d0de75d335f
Diffstat (limited to 'absl/numeric')
| -rw-r--r-- | absl/numeric/int128.cc | 3 | ||||
| -rw-r--r-- | absl/numeric/int128.h | 5 | ||||
| -rw-r--r-- | absl/numeric/int128_stream_test.cc | 6 | ||||
| -rw-r--r-- | absl/numeric/int128_test.cc | 2 |
4 files changed, 3 insertions, 13 deletions
diff --git a/absl/numeric/int128.cc b/absl/numeric/int128.cc index daa32b51..5d6c68d1 100644 --- a/absl/numeric/int128.cc +++ b/absl/numeric/int128.cc @@ -29,9 +29,6 @@ namespace absl { ABSL_NAMESPACE_BEGIN -ABSL_DLL const uint128 kuint128max = MakeUint128( - std::numeric_limits<uint64_t>::max(), std::numeric_limits<uint64_t>::max()); - namespace { // Returns the 0-based position of the last set bit (i.e., most significant bit) diff --git a/absl/numeric/int128.h b/absl/numeric/int128.h index 7530a793..a17d0e1b 100644 --- a/absl/numeric/int128.h +++ b/absl/numeric/int128.h @@ -244,11 +244,6 @@ class #endif // byte order }; -// Prefer to use the constexpr `Uint128Max()`. -// -// TODO(absl-team) deprecate kuint128max once migration tool is released. -ABSL_DLL extern const uint128 kuint128max; - // allow uint128 to be logged std::ostream& operator<<(std::ostream& os, uint128 v); diff --git a/absl/numeric/int128_stream_test.cc b/absl/numeric/int128_stream_test.cc index bd937847..1b058e17 100644 --- a/absl/numeric/int128_stream_test.cc +++ b/absl/numeric/int128_stream_test.cc @@ -135,11 +135,11 @@ TEST(Uint128, OStreamValueTest) { "2000000000000000000000000000000000000000000"}); CheckUint128Case({absl::MakeUint128(0x8000000000000000, 0), kHex, /*width = */ 0, "80000000000000000000000000000000"}); - CheckUint128Case({absl::kuint128max, kDec, /*width = */ 0, + CheckUint128Case({absl::Uint128Max(), kDec, /*width = */ 0, "340282366920938463463374607431768211455"}); - CheckUint128Case({absl::kuint128max, kOct, /*width = */ 0, + CheckUint128Case({absl::Uint128Max(), kOct, /*width = */ 0, "3777777777777777777777777777777777777777777"}); - CheckUint128Case({absl::kuint128max, kHex, /*width = */ 0, + CheckUint128Case({absl::Uint128Max(), kHex, /*width = */ 0, "ffffffffffffffffffffffffffffffff"}); } diff --git a/absl/numeric/int128_test.cc b/absl/numeric/int128_test.cc index 005ff9a4..f17a5f6b 100644 --- a/absl/numeric/int128_test.cc +++ b/absl/numeric/int128_test.cc @@ -231,8 +231,6 @@ TEST(Uint128, AllTests) { EXPECT_EQ(two, -((-one) - 1)); EXPECT_EQ(absl::Uint128Max(), -one); EXPECT_EQ(zero, -zero); - - EXPECT_EQ(absl::Uint128Max(), absl::kuint128max); } TEST(Int128, RightShiftOfNegativeNumbers) { |