diff options
| author | Andy Getzendanner <durandal@google.com> | 2023-05-23 15:46:35 -0700 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2023-05-23 15:47:23 -0700 |
| commit | 52747821480e6cadd8b27a0947af5d7933f9dfb4 (patch) | |
| tree | cc42f6dc30fa8eca19047efd799c769ead59b6c4 /absl/strings/internal/charconv_parse_test.cc | |
| parent | 79ca5d7aad63973c83a4962a66ab07cd623131ea (diff) | |
| download | abseil-52747821480e6cadd8b27a0947af5d7933f9dfb4.tar.gz abseil-52747821480e6cadd8b27a0947af5d7933f9dfb4.tar.bz2 abseil-52747821480e6cadd8b27a0947af5d7933f9dfb4.zip | |
Migrate most RAW_LOGs and RAW_CHECKs in tests to regular LOG and CHECK.
The non-RAW_ versions provide better output but weren't available when most of these tests were written.
There are just a couple spots where RAW_ is actually needed, e.g. signal handlers and malloc hooks.
Also fix a couple warnings in layout_test.cc newly surfaced because the optimizer understands CHECK_XX differently than INTERNAL_CHECK.
PiperOrigin-RevId: 534584435
Change-Id: I8d36fa809ffdaae5a3813064bd602cb8611c1613
Diffstat (limited to 'absl/strings/internal/charconv_parse_test.cc')
| -rw-r--r-- | absl/strings/internal/charconv_parse_test.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/absl/strings/internal/charconv_parse_test.cc b/absl/strings/internal/charconv_parse_test.cc index bc2d1118..2b7b0821 100644 --- a/absl/strings/internal/charconv_parse_test.cc +++ b/absl/strings/internal/charconv_parse_test.cc @@ -19,7 +19,7 @@ #include "gmock/gmock.h" #include "gtest/gtest.h" -#include "absl/base/internal/raw_logging.h" +#include "absl/log/check.h" #include "absl/strings/str_cat.h" using absl::chars_format; @@ -56,14 +56,14 @@ void ExpectParsedFloat(std::string s, absl::chars_format format_flags, begin_subrange = static_cast<int>(open_bracket_pos); s.replace(open_bracket_pos, 1, ""); std::string::size_type close_bracket_pos = s.find(']'); - ABSL_RAW_CHECK(close_bracket_pos != absl::string_view::npos, - "Test input contains [ without matching ]"); + CHECK_NE(close_bracket_pos, absl::string_view::npos) + << "Test input contains [ without matching ]"; end_subrange = static_cast<int>(close_bracket_pos); s.replace(close_bracket_pos, 1, ""); } const std::string::size_type expected_characters_matched = s.find('$'); - ABSL_RAW_CHECK(expected_characters_matched != std::string::npos, - "Input string must contain $"); + CHECK_NE(expected_characters_matched, std::string::npos) + << "Input string must contain $"; s.replace(expected_characters_matched, 1, ""); ParsedFloat parsed = |