diff options
| author | Derek Mauro <dmauro@google.com> | 2023-05-12 08:45:48 -0700 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2023-05-12 08:46:58 -0700 |
| commit | 3aa3377ef66e6388ed19fd7c862bf0dc3a3630e0 (patch) | |
| tree | 6ab3adb03426b67da67f4e8ac679dec8a7e8a7dc /absl/strings/internal/cord_internal.cc | |
| parent | 2526926b9275076b03159e7e0a9f1f32b9ed8d09 (diff) | |
| download | abseil-3aa3377ef66e6388ed19fd7c862bf0dc3a3630e0.tar.gz abseil-3aa3377ef66e6388ed19fd7c862bf0dc3a3630e0.tar.bz2 abseil-3aa3377ef66e6388ed19fd7c862bf0dc3a3630e0.zip | |
Fixed Windows DLL builds of test targets
This is a heavily modified version of
https://github.com/abseil/abseil-cpp/pull/1445,
which adds some missing test libraries to the test DLL.
Unlike #1445, this change moves several global variables out of
headers that did not need to be in headers.
For instance, cord_btree_exhaustive_validation was a global
defined/declared in cord_internal, but only used in cord_rep_btree
and its test.
cordz_handle defined a queue in its header even though it wasn't needed,
which also led to ODR problems.
The Spinlock used in CordzHandle is replaced with a Mutex. This was
originally a Mutex, but Chromium asked us to change it to a Spinlock
to avoid a static initializer. After this change, the static
initializer is no longer an issue.
#1407
PiperOrigin-RevId: 531516991
Change-Id: I0e431a193698b20ba03fac6e414c26f153f330a7
Diffstat (limited to 'absl/strings/internal/cord_internal.cc')
| -rw-r--r-- | absl/strings/internal/cord_internal.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/absl/strings/internal/cord_internal.cc b/absl/strings/internal/cord_internal.cc index b6b06cfa..b7874385 100644 --- a/absl/strings/internal/cord_internal.cc +++ b/absl/strings/internal/cord_internal.cc @@ -33,7 +33,6 @@ ABSL_CONST_INIT std::atomic<bool> cord_ring_buffer_enabled( kCordEnableRingBufferDefault); ABSL_CONST_INIT std::atomic<bool> shallow_subcords_enabled( kCordShallowSubcordsDefault); -ABSL_CONST_INIT std::atomic<bool> cord_btree_exhaustive_validation(false); void LogFatalNodeType(CordRep* rep) { ABSL_INTERNAL_LOG(FATAL, absl::StrCat("Unexpected node type: ", |