diff options
| author | Andy Getzendanner <durandal@google.com> | 2023-05-23 15:46:35 -0700 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2023-05-23 15:47:23 -0700 |
| commit | 52747821480e6cadd8b27a0947af5d7933f9dfb4 (patch) | |
| tree | cc42f6dc30fa8eca19047efd799c769ead59b6c4 /absl/strings/internal/str_format/convert_test.cc | |
| parent | 79ca5d7aad63973c83a4962a66ab07cd623131ea (diff) | |
| download | abseil-52747821480e6cadd8b27a0947af5d7933f9dfb4.tar.gz abseil-52747821480e6cadd8b27a0947af5d7933f9dfb4.tar.bz2 abseil-52747821480e6cadd8b27a0947af5d7933f9dfb4.zip | |
Migrate most RAW_LOGs and RAW_CHECKs in tests to regular LOG and CHECK.
The non-RAW_ versions provide better output but weren't available when most of these tests were written.
There are just a couple spots where RAW_ is actually needed, e.g. signal handlers and malloc hooks.
Also fix a couple warnings in layout_test.cc newly surfaced because the optimizer understands CHECK_XX differently than INTERNAL_CHECK.
PiperOrigin-RevId: 534584435
Change-Id: I8d36fa809ffdaae5a3813064bd602cb8611c1613
Diffstat (limited to 'absl/strings/internal/str_format/convert_test.cc')
| -rw-r--r-- | absl/strings/internal/str_format/convert_test.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/absl/strings/internal/str_format/convert_test.cc b/absl/strings/internal/str_format/convert_test.cc index 8b5a27ed..16ff9879 100644 --- a/absl/strings/internal/str_format/convert_test.cc +++ b/absl/strings/internal/str_format/convert_test.cc @@ -26,6 +26,7 @@ #include "gtest/gtest.h" #include "absl/base/attributes.h" #include "absl/base/internal/raw_logging.h" +#include "absl/log/log.h" #include "absl/strings/internal/str_format/bind.h" #include "absl/strings/match.h" #include "absl/types/optional.h" @@ -264,7 +265,7 @@ MATCHER_P(MatchesPointerString, ptr, "") { } void* parsed = nullptr; if (sscanf(arg.c_str(), "%p", &parsed) != 1) { - ABSL_RAW_LOG(FATAL, "Could not parse %s", arg.c_str()); + LOG(FATAL) << "Could not parse " << arg; } return ptr == parsed; } |