diff options
| author | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2023-06-12 02:06:49 +0200 |
|---|---|---|
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2023-06-12 02:07:59 +0200 |
| commit | f09a574a331527ccebdef88d5cc2e2c45fa072b4 (patch) | |
| tree | 697e59c3c10f031cf71655c60e15db3c4a70086a /device | |
| parent | ee2e9072964ce1615c9059a6141200244f9f9119 (diff) | |
| download | gnumach-f09a574a331527ccebdef88d5cc2e2c45fa072b4.tar.gz gnumach-f09a574a331527ccebdef88d5cc2e2c45fa072b4.tar.bz2 gnumach-f09a574a331527ccebdef88d5cc2e2c45fa072b4.zip | |
intr: Fix crash on irq notification port destruction
When the Linux IRQ driver is used we don't really control the list, so
we end up with a small leak.
Diffstat (limited to 'device')
| -rw-r--r-- | device/intr.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/device/intr.c b/device/intr.c index 996b1b32..15029440 100644 --- a/device/intr.c +++ b/device/intr.c @@ -106,7 +106,7 @@ deliver_user_intr (struct irqdev *dev, int id, user_intr_t *e) /* The reference of the port was increased * when the port was installed. If the reference is 1, it means * the port was deallocated and we should clean after it. */ - if (e->dst_port->ip_references == 1) + if (!e->dst_port || e->dst_port->ip_references == 1) { thread_wakeup ((event_t) &intr_thread); return 0; @@ -295,9 +295,16 @@ intr_thread (void) e->n_unacked--; } +#if 0 +#ifndef LINUX_DEV + // TODO: remove from the action list +#else + // FIXME: with the Linux irq handler we don't actually control the action list +#endif splx (s); kfree ((vm_offset_t) e, sizeof (*e)); s = splhigh (); +#endif } } while (del || irqtab.tot_num_intr); |