diff options
author | Flavio Cruz <flaviocruz@gmail.com> | 2022-11-30 02:14:20 -0500 |
---|---|---|
committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2022-11-30 22:26:30 +0100 |
commit | 958686efa2175abe3f7044890c2c2370e29147f2 (patch) | |
tree | f4052284d57e063d7f1b3583a3b8a387cba0cd3f /ipc/ipc_notify.c | |
parent | 0afd533bfef628d0ef8476bbaaab78c6a1336873 (diff) | |
download | gnumach-958686efa2175abe3f7044890c2c2370e29147f2.tar.gz gnumach-958686efa2175abe3f7044890c2c2370e29147f2.tar.bz2 gnumach-958686efa2175abe3f7044890c2c2370e29147f2.zip |
Update ipc/ directory to use mach_port_name_t
Make it explicit where we use port names versus actual ports. For the 64
bit kernel, port names and ports are of different size so this corrects
the syscall arguments and internal structs to have the right size.
This patch also uncovered several issues we need to solve to make
GNUMach work well on 64 bits. First, the mach_msg call will receive 4
byte port names while the kernel "thinks" they are 8 bytes, which will
be a problem. Also, when we send a message, the kernel translates the
port names into port pointers in the message copied from user space.
This also won't work on 64 bits. In this patch, I added several TODOs to fix
the issues later.
Message-Id: <Y4cCzNmc6vC4bjsX@viriathus>
Diffstat (limited to 'ipc/ipc_notify.c')
-rw-r--r-- | ipc/ipc_notify.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/ipc/ipc_notify.c b/ipc/ipc_notify.c index df5f68bc..1fff8ead 100644 --- a/ipc/ipc_notify.c +++ b/ipc/ipc_notify.c @@ -253,15 +253,15 @@ ipc_notify_init(void) void ipc_notify_port_deleted( - ipc_port_t port, - mach_port_t name) + ipc_port_t port, + mach_port_name_t name) { ipc_kmsg_t kmsg; mach_port_deleted_notification_t *n; kmsg = ikm_alloc(sizeof *n); if (kmsg == IKM_NULL) { - printf("dropped port-deleted (0x%p, 0x%lx)\n", port, name); + printf("dropped port-deleted (0x%p, 0x%x)\n", port, name); ipc_port_release_sonce(port); return; } @@ -287,15 +287,15 @@ ipc_notify_port_deleted( void ipc_notify_msg_accepted( - ipc_port_t port, - mach_port_t name) + ipc_port_t port, + mach_port_name_t name) { ipc_kmsg_t kmsg; mach_msg_accepted_notification_t *n; kmsg = ikm_alloc(sizeof *n); if (kmsg == IKM_NULL) { - printf("dropped msg-accepted (0x%p, 0x%lx)\n", port, name); + printf("dropped msg-accepted (0x%p, 0x%x)\n", port, name); ipc_port_release_sonce(port); return; } @@ -425,15 +425,15 @@ ipc_notify_send_once(ipc_port_t port) void ipc_notify_dead_name( - ipc_port_t port, - mach_port_t name) + ipc_port_t port, + mach_port_name_t name) { ipc_kmsg_t kmsg; mach_dead_name_notification_t *n; kmsg = ikm_alloc(sizeof *n); if (kmsg == IKM_NULL) { - printf("dropped dead-name (0x%p, 0x%lx)\n", port, name); + printf("dropped dead-name (0x%p, 0x%x)\n", port, name); ipc_port_release_sonce(port); return; } |