diff options
| author | Flavio Cruz <flaviocruz@gmail.com> | 2022-11-30 02:14:20 -0500 |
|---|---|---|
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2022-11-30 22:26:30 +0100 |
| commit | 958686efa2175abe3f7044890c2c2370e29147f2 (patch) | |
| tree | f4052284d57e063d7f1b3583a3b8a387cba0cd3f /ipc/mach_rpc.c | |
| parent | 0afd533bfef628d0ef8476bbaaab78c6a1336873 (diff) | |
| download | gnumach-958686efa2175abe3f7044890c2c2370e29147f2.tar.gz gnumach-958686efa2175abe3f7044890c2c2370e29147f2.tar.bz2 gnumach-958686efa2175abe3f7044890c2c2370e29147f2.zip | |
Update ipc/ directory to use mach_port_name_t
Make it explicit where we use port names versus actual ports. For the 64
bit kernel, port names and ports are of different size so this corrects
the syscall arguments and internal structs to have the right size.
This patch also uncovered several issues we need to solve to make
GNUMach work well on 64 bits. First, the mach_msg call will receive 4
byte port names while the kernel "thinks" they are 8 bytes, which will
be a problem. Also, when we send a message, the kernel translates the
port names into port pointers in the message copied from user space.
This also won't work on 64 bits. In this patch, I added several TODOs to fix
the issues later.
Message-Id: <Y4cCzNmc6vC4bjsX@viriathus>
Diffstat (limited to 'ipc/mach_rpc.c')
| -rw-r--r-- | ipc/mach_rpc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ipc/mach_rpc.c b/ipc/mach_rpc.c index 6ca46cc9..7b747f79 100644 --- a/ipc/mach_rpc.c +++ b/ipc/mach_rpc.c @@ -105,7 +105,7 @@ mach_port_rpc_copy( tname = ipc_object_copyin_type(portp->msgt_name); if (!IO_VALID(iname)) { - portp->name = (mach_port_t) iname; + portp->name = (mach_port_name_t) iname; portp->msgt_name = tname; #ifdef DEBUG_MPRC printf("iport %x invalid\n", iname); @@ -114,7 +114,7 @@ mach_port_rpc_copy( } if (ISKERNELACT(dact)) { - portp->name = (mach_port_t) iname; + portp->name = (mach_port_name_t) iname; kr = KERN_SUCCESS; } else { kr = ipc_object_copyout(dspace, iname, tname, TRUE, |