x86_64: expand and shrink messages in copy{in, out}msg routines

* i386/i386/copy_user.h: new file to handle 32/64 bit differences
  - add msg_usize() to recontruct the user-space message size
  - add copyin/copyout helpers for addresses and ports
* include/mach/message.h: add msg alignment macros
* ipc/ipc_kmsg.c:
  - copyin/out ports names instead of using pointer magic
* ipc/ipc_mqueue.c: use msg_usize() to check if we can actually
  receive the message
* ipc/mach_msg.c: Likewise for continuations in receive path
* x86_64/Makefrag.am: add x86_64/copy_user.c
* x86_64/copy_user.c: new file to handle message expansion and
  shrinking during copyinmsg/copyoutmsg for 64 bit kernels.
  - port names -> port pointers on all 64-bit builds
  - 32-bit pointer -> 64 bit pointer when using 32-bit userspace
* x86_64/locore.S: remove copyinmsg() and copyoutmsg()
Message-Id: <20230116105857.240210-3-luca@orpolo.org>

1 files changed, 0 insertions, 81 deletions

diff --git a/x86_64/locore.S b/x86_64/locore.S
index f81886da..21a3e373 100644
--- a/x86_64/locore.S
+++ b/x86_64/locore.S
@@ -1329,48 +1329,6 @@ copyin_fail:
 	movq	$1,%rax			/* return 1 for failure */
 	jmp	copyin_ret		/* pop frame and return */
 
-/*
- * Copy from user address space - version for copying messages.
- * arg0:	user address
- * arg1:	kernel address
- * arg2:	byte count
- */
-ENTRY(copyinmsg)
-	xchgq   %rsi,%rdi		/* Get user source and kernel destination */
-	movl	%edx,MSGH_MSGH_SIZE(%rdi)	/* set msgh_size already */
-
-/* 32 on 64 conversion */
-	subq	$32,%rdx
-	js	bogus
-
-	/* Copy msgh_bits */
-	RECOVER(copyin_fail)
-	movsl
-
-	/* Copy msgh_size */
-	RECOVER(copyin_fail)
-	lodsl
-        /* But don't actually store it: we have already set it above to what we
-           really copy */
-	addq	$4,%rdi
-
-	xorq	%rax,%rax
-	/* Copy msgh_remote_port */
-	RECOVER(copyin_fail)
-	lodsl
-	stosq
-
-	/* Copy msgh_local_port */
-	RECOVER(copyin_fail)
-	lodsl
-	stosq
-
-	/* Copy msgh_seqno and msgh_id */
-	RECOVER(copyin_fail)
-	movsq
-
-	jmp	copyin_remainder
-
 bogus:
 	ud2
 
@@ -1400,45 +1358,6 @@ copyout_fail:
 	jmp	copyout_ret		/* pop frame and return */
 
 /*
- * Copy to user address space.
- * arg0:	kernel address
- * arg1:	user address
- * arg2:	byte count
- */
-ENTRY(copyoutmsg)
-	xchgq   %rsi,%rdi		/* Get user source and kernel destination */
-
-/* 32 on 64 conversion */
-	subq	$32,%rdx
-	js	bogus
-
-	/* Copy msgh_bits */
-	RECOVER(copyout_fail)
-	movsl
-
-	/* Copy msgh_size */
-	lodsl
-	subl	$8,%eax
-	RECOVER(copyout_fail)
-	stosl
-
-	/* Copy msgh_remote_port */
-	lodsq
-	RECOVER(copyout_fail)
-	stosl
-
-	/* Copy msgh_local_port */
-	lodsq
-	RECOVER(copyout_fail)
-	stosl
-
-	/* Copy msgh_seqno and msgh_id */
-	RECOVER(copyout_fail)
-	movsq
-
-	jmp	copyin_remainder
-
-/*
  * int inst_fetch(int eip, int cs);
  *
  * Fetch instruction byte.  Return -1 if invalid address.