diff options
| author | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2025-01-17 01:36:15 +0100 |
|---|---|---|
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2025-01-17 01:37:07 +0100 |
| commit | ac590dcfe1f359bacc4e1be9008a02a2a74f0702 (patch) | |
| tree | dd615ca680d3e021748b0574dd42ec673afe68fd | |
| parent | 5b1b28a23bcb71aba6721e839dc2bad4d7daa782 (diff) | |
| download | hurd-ac590dcfe1f359bacc4e1be9008a02a2a74f0702.tar.gz hurd-ac590dcfe1f359bacc4e1be9008a02a2a74f0702.tar.bz2 hurd-ac590dcfe1f359bacc4e1be9008a02a2a74f0702.zip | |
libdiskfs: Avoid crashing on system shutdown
when processes which were upgraded didn't get restarted, and stop after
making the filesystem readonly.
| -rw-r--r-- | libdiskfs/node-drop.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/libdiskfs/node-drop.c b/libdiskfs/node-drop.c index 6a8ebd6d..00c84408 100644 --- a/libdiskfs/node-drop.c +++ b/libdiskfs/node-drop.c @@ -38,11 +38,13 @@ diskfs_drop_node (struct node *np) { mode_t savemode; - if (np->dn_stat.st_nlink == 0) + /* XXX: if the filesystem is readonly, we cannot remove the files with no link + but e.g. memory mapping still in memory. This notably happens when + upgrading packages without restarting the corresponding processes. Fsck + will have to fix them. */ + if (np->dn_stat.st_nlink == 0 && !diskfs_readonly) { diskfs_check_readonly (); - // Pb when remounted readonly :/ - assert_backtrace (!diskfs_readonly); if (np->dn_stat.st_mode & S_IPTRANS) diskfs_set_translator (np, 0, 0, 0); |