diff options
| author | Sergey Bugaev <bugaevc@gmail.com> | 2024-03-23 14:53:14 +0300 |
|---|---|---|
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2024-03-23 13:02:19 +0100 |
| commit | 14d294e2014b188cce8f5a79dd46cf62cd9a86aa (patch) | |
| tree | 7b90df438a7141c501fc466adddf2e03d7318a07 /exec | |
| parent | 5d7055b305624d6e271e2fc57e67aa5b65039486 (diff) | |
| download | hurd-14d294e2014b188cce8f5a79dd46cf62cd9a86aa.tar.gz hurd-14d294e2014b188cce8f5a79dd46cf62cd9a86aa.tar.bz2 hurd-14d294e2014b188cce8f5a79dd46cf62cd9a86aa.zip | |
exec: Fix creating executable stacks
The previous logic had two independent issues:
* We need to make the stack executable if either the program or its ELF
interpreter requires executable stack. In practice, it's common for
the program itself to not require executable stack, but ld.so (glibc)
needs it.
* mach_setup_thread () allocates stacks with a simple vm_allocate (),
which creates non-executable memory. So if an executable stack is
required, the stack has to be vm_protect'ed to enable execution, not
the other way around. As the comment suggest, it would've been better
to use vm_map () with the desired protection directly.
Message-ID: <20240323115322.69075-2-bugaevc@gmail.com>
Diffstat (limited to 'exec')
| -rw-r--r-- | exec/exec.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/exec/exec.c b/exec/exec.c index 639564cb..f6788520 100644 --- a/exec/exec.c +++ b/exec/exec.c @@ -1335,11 +1335,12 @@ do_exec (file_t file, if (e.error) goto out; - /* It would probably be better to change mach_setup_thread so - it does a vm_map with the right permissions to start with. */ - if (!e.info.elf.execstack) + /* mach_setup_thread () creates non-executable stacks (with vm_allocate ()). + It would probably be better to change mach_setup_thread () so it does + a vm_map () with the right permissions to start with. */ + if (e.info.elf.execstack || (e.interp.section && interp.info.elf.execstack)) e.error = vm_protect (newtask, boot->stack_base, boot->stack_size, - 0, VM_PROT_READ | VM_PROT_WRITE); + 0, VM_PROT_READ | VM_PROT_WRITE | VM_PROT_EXECUTE); if (oldtask != newtask && oldtask != MACH_PORT_NULL) { |