diff options
| author | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2023-01-01 13:30:19 +0100 |
|---|---|---|
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2023-01-01 14:04:51 +0100 |
| commit | 938730662dd2ec407c28380de66c3053f05e3159 (patch) | |
| tree | f434e727eee8988504416452e083dc64f1607d0e /libdiskfs | |
| parent | 08de8baa4917b20644f9340452825bceadad6693 (diff) | |
| download | hurd-938730662dd2ec407c28380de66c3053f05e3159.tar.gz hurd-938730662dd2ec407c28380de66c3053f05e3159.tar.bz2 hurd-938730662dd2ec407c28380de66c3053f05e3159.zip | |
Fix accessing cred before checking it is non-NULL
Diffstat (limited to 'libdiskfs')
| -rw-r--r-- | libdiskfs/file-lock.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/libdiskfs/file-lock.c b/libdiskfs/file-lock.c index b95c3f0c..0446fc3d 100644 --- a/libdiskfs/file-lock.c +++ b/libdiskfs/file-lock.c @@ -27,7 +27,7 @@ diskfs_S_file_lock (struct protid *cred, int flags) error_t err; struct flock64 lock; struct node *node; - int openstat = cred->po->openstat; + int openstat; mach_port_t rendezvous = MACH_PORT_NULL; if (! cred) @@ -51,6 +51,7 @@ diskfs_S_file_lock (struct protid *cred, int flags) From flock(2): A shared or exclusive lock can be placed on a file regardless of the mode in which the file was opened. */ + openstat = cred->po->openstat; if (openstat & (O_RDONLY|O_WRONLY|O_EXEC)) openstat |= O_RDONLY|O_WRONLY; node = cred->po->np; |