aboutsummaryrefslogtreecommitdiff
path: root/libps/proclist.c
diff options
context:
space:
mode:
authorFlavio Cruz <flaviocruz@gmail.com>2023-04-08 01:03:31 -0400
committerSamuel Thibault <samuel.thibault@ens-lyon.org>2023-04-08 10:55:59 +0200
commita096270c77b1f6461a2ef58660ad9cfa9cbb32bb (patch)
treeb9c713ad70ae6705a1dfe6d76c35c0d918515d2e /libps/proclist.c
parent5de1b81f0bb24ba38d0a819bba9bd526863b5385 (diff)
downloadhurd-a096270c77b1f6461a2ef58660ad9cfa9cbb32bb.tar.gz
hurd-a096270c77b1f6461a2ef58660ad9cfa9cbb32bb.tar.bz2
hurd-a096270c77b1f6461a2ef58660ad9cfa9cbb32bb.zip
Further modernize Hurd code by enforcing strict prototypes and no implicit function declarations.
Most of the changes land in one of these buckets: * Removed unused declarations. * Used (void) to represent no parameters instead of () which means an undeterminate number of parameters. * Included missing header files whenever necessary (stdlib.h, sys/mman.h, etc) * Typedefed function pointers to be able to fully declare the parameter types. * Added declarations of library functions that are used elsewhere (example is libps/ps.h). * Made functions static whenever they are only used in that file. * Forwarded declarations of some methods that were made static. Message-Id: <ZDD1o7/tVYeZew+G@jupiter.tail36e24.ts.net>
Diffstat (limited to 'libps/proclist.c')
-rw-r--r--libps/proclist.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/libps/proclist.c b/libps/proclist.c
index c9ceaf0a..814ae30e 100644
--- a/libps/proclist.c
+++ b/libps/proclist.c
@@ -459,9 +459,7 @@ proc_stat_list_filter (struct proc_stat_list *pp,
error_t
proc_stat_list_sort1 (struct proc_stat_list *pp,
const struct ps_getter *getter,
- int (*cmp_fn)(struct proc_stat *ps1,
- struct proc_stat *ps2,
- const struct ps_getter *getter),
+ proc_stat_cmp_fun cmp_fn,
int reverse)
{
int needs = ps_getter_needs (getter);
@@ -521,7 +519,7 @@ error_t
proc_stat_list_sort (struct proc_stat_list *pp,
const struct ps_fmt_spec *key, int reverse)
{
- int (*cmp_fn)() = ps_fmt_spec_compare_fn (key);
+ proc_stat_cmp_fun cmp_fn = ps_fmt_spec_compare_fn (key);
if (cmp_fn == NULL)
return EINVAL;
else