diff options
| author | Damien Zammit <damien@zamaudio.com> | 2019-11-03 21:35:57 +0100 |
|---|---|---|
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2019-11-03 21:37:57 +0100 |
| commit | b160d6f3b3cdcd6a293c33cd89dcc46ab54c3264 (patch) | |
| tree | babcc0b5db069672277131e914beef6d6b4dddc5 /pci-arbiter/TODO | |
| parent | 084e5a86e5eca77cec49e08e0d83fe8266eca91b (diff) | |
| download | hurd-b160d6f3b3cdcd6a293c33cd89dcc46ab54c3264.tar.gz hurd-b160d6f3b3cdcd6a293c33cd89dcc46ab54c3264.tar.bz2 hurd-b160d6f3b3cdcd6a293c33cd89dcc46ab54c3264.zip | |
pci-arbiter: Use libpciaccess instead of embedding it
This patch removes all embedded pciaccess code from the arbiter
and instead uses the external pciaccess library.
* pci-arbiter/Makefile:
* Remove pci_access.c and x86_pci.c from the sources.
* pci-arbiter/func_files.c:
* io_config_file: Use a harcoded PCI config size.
* read_rom_file:
Grab the full rom first, then return the
requested amount.
* pci-arbiter/main.c:
* main: Call create_fs_tree() w/o pci_sys.
Since it's not part of the translator anymore.
* pci-arbiter/netfs_impl.c:
* netfs_attempt_read:
Send pci_device_cfg_read() as the read op.
* netfs_attempt_write:
Send pci_device_cfg_write() as the write op.
* pci-arbiter/pci-ops.c:
* S_pci_conf_read: Call libpciaccess' pci_device_cfg_read().
* S_pci_conf_write: Call libpciaccess' pci_device_cfg_write().
* S_pci_get_dev_rom:
Set rom.base_addr to zero for the moment, until
libpciaccess esposes it properly.
* pci-arbiter/pci_access.c: Deleted
* pci-arbiter/pci_access.h: Deleted
* pci-arbiter/pcifs.c:
* create_fs_tree:
Remove the pci_sys parameter.
Use libpciaccess' iterator.
Use a hardcoded config space size.
* pci-arbiter/pcifs.h: Definitions for changes in pcifs.c.
* pci-arbiter/x86_pci.c: Deleted.
* pci-arbiter/x86_pci.h: Deleted.
Diffstat (limited to 'pci-arbiter/TODO')
| -rw-r--r-- | pci-arbiter/TODO | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/pci-arbiter/TODO b/pci-arbiter/TODO index 22ae72a8..20060842 100644 --- a/pci-arbiter/TODO +++ b/pci-arbiter/TODO @@ -5,11 +5,10 @@ - pci_get_ndevs should be deprecated, applications shouldn't be relying on this -- we shouldn't duplicate pci_access.[ch] x86_pci.[ch] from libpciaccess, we - should get libpciaccess to expose pci_system_x86_create() to keep the - maintenance of x86 port knocking there. +- In pci-ops.c - config_block_op: + Update len with remaining allowed size once op() returns EIO + so that we get short reads/writes implemented by leaving it to pciaccess - At least one difference with libpciaccess is the refresh operation. Perhaps - we'd need to extend libpciaccess to fix that. +- Upstream hurdish access method + x86 fixes to libpciaccess BTW we could also support libpci. |