Fix double call to pthread_mutex_unlock in S_socket_connect.

* pflocal/socker.c (S_socket_connect): fix redundant call to
pthread_mutex_unlock. There is no need to hold sock->lock to call
connq_connect_cancel, and sock->lock must be taken when leaving the if/else
blocks.

1 files changed, 1 insertions, 1 deletions

diff --git a/pflocal/socket.c b/pflocal/socket.c
index 46749fee..65da7487 100644
--- a/pflocal/socket.c
+++ b/pflocal/socket.c
@@ -139,11 +139,11 @@ S_socket_connect (struct sock_user *user, struct addr *addr)
 			sock_free (server);
 		    }
 
-	          pthread_mutex_lock (&sock->lock);
 		  if (err)
 		    connq_connect_cancel (peer->listen_queue);
 		}
 
+              pthread_mutex_lock (&sock->lock);
 	      /* We must set CONNECT_QUEUE to NULL, as no one else can
 		 set it until we've done so.  */
 	      sock->connect_queue = NULL;